You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by we...@apache.org on 2018/08/17 16:56:21 UTC

[parquet-cpp] branch master updated: PARQUET-1384: fix clang build error for bloom_filter-test.cc

This is an automated email from the ASF dual-hosted git repository.

wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/parquet-cpp.git


The following commit(s) were added to refs/heads/master by this push:
     new 79a1bc5  PARQUET-1384: fix clang build error for bloom_filter-test.cc
79a1bc5 is described below

commit 79a1bc5d5368bd780a2c0e745d28f562e248a59f
Author: Chen, Junjie <cj...@gmail.com>
AuthorDate: Fri Aug 17 12:56:15 2018 -0400

    PARQUET-1384: fix clang build error for bloom_filter-test.cc
    
    replace https://github.com/apache/parquet-cpp/pull/488
    
    Author: Chen, Junjie <cj...@gmail.com>
    
    Closes #490 from cjjnjust/parquet-1384 and squashes the following commits:
    
    31afdd8 [Chen, Junjie] PARQUET-1384: fix clang build error for bloom_filter-test.cc
---
 src/parquet/bloom_filter-test.cc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/parquet/bloom_filter-test.cc b/src/parquet/bloom_filter-test.cc
index 69583af..96d2e06 100644
--- a/src/parquet/bloom_filter-test.cc
+++ b/src/parquet/bloom_filter-test.cc
@@ -165,7 +165,7 @@ TEST(CompatibilityTest, TestBloomFilter) {
 
   std::unique_ptr<uint8_t[]> bitset(new uint8_t[size]());
   std::shared_ptr<Buffer> buffer(new Buffer(bitset.get(), size));
-  handle->Read(size, &buffer);
+  PARQUET_THROW_NOT_OK(handle->Read(size, &buffer));
 
   InMemoryInputStream source(buffer);
   BlockSplitBloomFilter bloom_filter1 = BlockSplitBloomFilter::Deserialize(&source);
@@ -192,10 +192,10 @@ TEST(CompatibilityTest, TestBloomFilter) {
   bloom_filter2.WriteTo(&sink);
   std::shared_ptr<Buffer> buffer1 = sink.GetBuffer();
 
-  handle->Seek(0);
-  handle->GetSize(&size);
+  PARQUET_THROW_NOT_OK(handle->Seek(0));
+  PARQUET_THROW_NOT_OK(handle->GetSize(&size));
   std::shared_ptr<Buffer> buffer2;
-  handle->Read(size, &buffer2);
+  PARQUET_THROW_NOT_OK(handle->Read(size, &buffer2));
 
   EXPECT_TRUE((*buffer1).Equals(*buffer2));
 }