You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/09 03:30:28 UTC

[GitHub] [pinot] walterddr commented on pull request #7804: add validator for SDF

walterddr commented on pull request #7804:
URL: https://github.com/apache/pinot/pull/7804#issuecomment-989476002


   Updated the logic. agree that validation logics should not be part of SPI.
   However in this case I think DateTimeFormatSpec / DateTimeFormatPatternSpec should not be in SPI either, they are concrete and has nothing to do with the SPI to begin with. 
   
   I will try to move them out in follow up PR, otherwise it looks like there's multiple layer of validation done in different stages and it is just weird. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org