You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Martin Webb <ma...@gmail.com> on 2008/01/11 13:41:08 UTC
Feature dynamic-height is the method adjustHeight or _IG_AdjustIFrameHeight
The Google Gadget API specifies using the _IG_AdjustIFrameHeight method
within the gadget, yet this method is not exposed as a skeleton method
within dynamic-height.js feature, instead it exposes:
gadgets.Window.adjustHeight = function(opt_height) {
// TODO
};
Is the intention to expose adjustHeight, _IG_AdjustIFrameHeight,
_AdjustIFrameHeight or something else? Any change to the method name will
cause gadgets that comply with the Google Gadget API when run on shindig to
fail with:
Error: _IG_AdjustIFrameHeight is not defined
Not raised as a Jira issue yet - as I may have missed something obvious?
Regards
Martin
Re: Feature dynamic-height is the method adjustHeight or _IG_AdjustIFrameHeight
Posted by David Glazer <dg...@google.com>.
The intent is to encourage use of the new method, but support use of the old
method for backwards compatibility. I don't know where the "backwards
compatibility shim" is supposed to live, or whether it's in the code yet.
- dG
On Jan 11, 2008 4:41 AM, Martin Webb <ma...@gmail.com> wrote:
> The Google Gadget API specifies using the _IG_AdjustIFrameHeight method
> within the gadget, yet this method is not exposed as a skeleton method
> within dynamic-height.js feature, instead it exposes:
>
> gadgets.Window.adjustHeight = function(opt_height) {
> // TODO
> };
>
> Is the intention to expose adjustHeight, _IG_AdjustIFrameHeight,
> _AdjustIFrameHeight or something else? Any change to the method name will
> cause gadgets that comply with the Google Gadget API when run on shindig
> to
> fail with:
>
> Error: _IG_AdjustIFrameHeight is not defined
>
> Not raised as a Jira issue yet - as I may have missed something obvious?
>
> Regards
> Martin
>
Re: Feature dynamic-height is the method adjustHeight or _IG_AdjustIFrameHeight
Posted by Zhen Wang <zh...@apache.org>.
Yes, _IG_AdjustIFrameHeight accepts an optional parameter.
On Jan 11, 2008 1:37 PM, Martin Webb <ma...@gmail.com> wrote:
> On 11/01/2008, Bruno Bowden <br...@google.com> wrote:
> >
> > As they say... look at the code. Zhen just checked this in:
> >
> > +gadgets.Window.adjustHeight = function(opt_height) {
> > + // TODO
> > +};
> >
>
>
> Did _IG_AdjustIFrameHeight() accept a opt_height?
>
Re: Feature dynamic-height is the method adjustHeight or _IG_AdjustIFrameHeight
Posted by Martin Webb <ma...@gmail.com>.
On 11/01/2008, Bruno Bowden <br...@google.com> wrote:
>
> As they say... look at the code. Zhen just checked this in:
>
> +gadgets.Window.adjustHeight = function(opt_height) {
> + // TODO
> +};
>
Did _IG_AdjustIFrameHeight() accept a opt_height?
Re: Feature dynamic-height is the method adjustHeight or _IG_AdjustIFrameHeight
Posted by Bruno Bowden <br...@google.com>.
As they say... look at the code. Zhen just checked this in:
+gadgets.Window.adjustHeight = function(opt_height) {
+ // TODO
+};
http://svn.apache.org/viewvc/incubator/shindig/trunk/features/dynamic-height/dynamic-height.js?view=log&pathrev=611045
On Jan 11, 2008 8:59 AM, Kevin Brown <et...@google.com> wrote:
> All of the _IG_* methods are deprecated, and there are equivalent
> replacements for them somewhere in the gadgets.* namespace.
>
> The replacements for _IG_AdjustIFrameHeight and _IG_SetTitle have not yet
> been implemented in Shindig, but they should be there within the next
> couple
> of days.
>
> For backwards compatibility support, the structure is as follows:
>
> - All core BC mappings are in features/core/legacy.js
> - BC mappings for individual libraries, such as dynamic-height or settitle
> are included in the new library
>
> On Jan 11, 2008 4:41 AM, Martin Webb <ma...@gmail.com> wrote:
>
> > The Google Gadget API specifies using the _IG_AdjustIFrameHeight method
> > within the gadget, yet this method is not exposed as a skeleton method
> > within dynamic-height.js feature, instead it exposes:
> >
> > gadgets.Window.adjustHeight = function(opt_height) {
> > // TODO
> > };
> >
> > Is the intention to expose adjustHeight, _IG_AdjustIFrameHeight,
> > _AdjustIFrameHeight or something else? Any change to the method name
> will
> > cause gadgets that comply with the Google Gadget API when run on shindig
> > to
> > fail with:
> >
> > Error: _IG_AdjustIFrameHeight is not defined
> >
> > Not raised as a Jira issue yet - as I may have missed something obvious?
> >
> > Regards
> > Martin
> >
>
Re: Feature dynamic-height is the method adjustHeight or _IG_AdjustIFrameHeight
Posted by Kevin Brown <et...@google.com>.
All of the _IG_* methods are deprecated, and there are equivalent
replacements for them somewhere in the gadgets.* namespace.
The replacements for _IG_AdjustIFrameHeight and _IG_SetTitle have not yet
been implemented in Shindig, but they should be there within the next couple
of days.
For backwards compatibility support, the structure is as follows:
- All core BC mappings are in features/core/legacy.js
- BC mappings for individual libraries, such as dynamic-height or settitle
are included in the new library
On Jan 11, 2008 4:41 AM, Martin Webb <ma...@gmail.com> wrote:
> The Google Gadget API specifies using the _IG_AdjustIFrameHeight method
> within the gadget, yet this method is not exposed as a skeleton method
> within dynamic-height.js feature, instead it exposes:
>
> gadgets.Window.adjustHeight = function(opt_height) {
> // TODO
> };
>
> Is the intention to expose adjustHeight, _IG_AdjustIFrameHeight,
> _AdjustIFrameHeight or something else? Any change to the method name will
> cause gadgets that comply with the Google Gadget API when run on shindig
> to
> fail with:
>
> Error: _IG_AdjustIFrameHeight is not defined
>
> Not raised as a Jira issue yet - as I may have missed something obvious?
>
> Regards
> Martin
>