You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by bu...@apache.org on 2011/11/08 17:27:19 UTC
DO NOT REPLY [Bug 52151] [PATCH] A code-coverage tool for code
analysis
https://issues.apache.org/bugzilla/show_bug.cgi?id=52151
--- Comment #1 from Vincent Hennebert <vh...@gmail.com> 2011-11-08 16:27:19 UTC ---
Hi Mehdi,
There's no jacoco.xml in the patch?
Also, I assume you changed the hyphenation test so that it matches the
*TestCase pattern. This is a good idea but setting the system property in the
getParameters method probably is a bit too much magic. Plus you have to reset
the property afterwards, which is brittle. Maybe the
LayoutEngingTestUtils.getLayoutTestFiles method should be overloaded with a
parameter that directly sets the test set instead of getting it from a system
property.
Small detail in the junit-compile-copy-resources task in build.xml: by using
the '**/*' pattern the Java files will also be copied, which will create
unnecessary I/O.
Thanks,
Vincent
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.