[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1362: refactor(conf): use DSN_DEFINE_double to load double type of configs

["empiredan (via GitHub)" <gi...@apache.org>]

empiredan commented on code in PR #1362:
URL: https://github.com/apache/incubator-pegasus/pull/1362#discussion_r1116472308


##########
src/runtime/service_api_c.cpp:
##########
@@ -50,6 +50,15 @@
 #include "utils/time_utils.h"
 #include "utils/process_utils.h"
 
+#ifdef DSN_ENABLE_GPERF
+DSN_DEFINE_double(core,
+                  tcmalloc_release_rate,
+                  1.,
+                  "the memory releasing rate of tcmalloc, default "
+                  "is 1.0 in gperftools, value range is "
+                  "[0.0~10.0]");

Review Comment:
   ```suggestion
                     "[0.0, 10.0]");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org