You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Henry Saputra (Created) (JIRA)" <ji...@apache.org> on 2011/12/29 06:40:30 UTC
[jira] [Created] (SHINDIG-1678) The flash transport to support RPc
for IE7 has problem with multiple gadgets in a single container
The flash transport to support RPc for IE7 has problem with multiple gadgets in a single container
--------------------------------------------------------------------------------------------------
Key: SHINDIG-1678
URL: https://issues.apache.org/jira/browse/SHINDIG-1678
Project: Shindig
Issue Type: Bug
Components: Javascript
Affects Versions: 2.0.2, 3.0.0
Reporter: Henry Saputra
The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
The flash component act as singleton to the transport ready() function is only called once even though multiple gadget calls gadgets.rpc.setupReceiver()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1678) The flash transport to support
RPC for IE7 has problem with multiple gadgets in a single container
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189931#comment-13189931 ]
jiraposter@reviews.apache.org commented on SHINDIG-1678:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3566/#review4496
-----------------------------------------------------------
Ship it!
LGTM. Thanks Henry! To clarify, is this only an issue in IE7 or would it be an issue with any browser that uses the flash transport? Theoretically you could force RPC to always use flash, regardless of the browser, by setting rpctx=flash in the query params. See rpc.js#getTransport()
trunk/features/src/main/javascript/features/rpc/flash.transport.js
<https://reviews.apache.org/r/3566/#comment10086>
Out of curiosity, how did you come up with this number?
- Stanton
On 2012-01-20 16:53:37, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3566/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-20 16:53:37)
bq.
bq.
bq. Review request for shindig and johnfargo.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container" https://issues.apache.org/jira/browse/SHINDIG-1678 for detail description about the review.
bq.
bq. Proposed fix is to flush the handshakes objects whenever new gadgets call gadgets.rpc.setupReceiver is called to make sure the container side register the child iframe info to the flash component.
bq.
bq.
bq. This addresses bug SHINDIG-1678.
bq. https://issues.apache.org/jira/browse/SHINDIG-1678
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/features/src/main/javascript/features/rpc/flash.transport.js 1233272
bq.
bq. Diff: https://reviews.apache.org/r/3566/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Running multiple gadgets in common container in IE7
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1678) The flash transport to support
RPC for IE7 has problem with multiple gadgets in a single container
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191181#comment-13191181 ]
jiraposter@reviews.apache.org commented on SHINDIG-1678:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3566/#review4535
-----------------------------------------------------------
Ship it!
LGTM
- Dan
On 2012-01-20 16:53:37, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3566/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-20 16:53:37)
bq.
bq.
bq. Review request for shindig and johnfargo.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container" https://issues.apache.org/jira/browse/SHINDIG-1678 for detail description about the review.
bq.
bq. Proposed fix is to flush the handshakes objects whenever new gadgets call gadgets.rpc.setupReceiver is called to make sure the container side register the child iframe info to the flash component.
bq.
bq.
bq. This addresses bug SHINDIG-1678.
bq. https://issues.apache.org/jira/browse/SHINDIG-1678
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/features/src/main/javascript/features/rpc/flash.transport.js 1233272
bq.
bq. Diff: https://reviews.apache.org/r/3566/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Running multiple gadgets in common container in IE7
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SHINDIG-1678) The flash transport to support RPc
for IE7 has problem with multiple gadgets in a single container
Posted by "Henry Saputra (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra reassigned SHINDIG-1678:
--------------------------------------
Assignee: Henry Saputra
> The flash transport to support RPc for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1678) The flash transport to support
RPC for IE7 has problem with multiple gadgets in a single container
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189896#comment-13189896 ]
jiraposter@reviews.apache.org commented on SHINDIG-1678:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3566/
-----------------------------------------------------------
Review request for shindig and johnfargo.
Summary
-------
See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container" https://issues.apache.org/jira/browse/SHINDIG-1678 for detail description about the review.
Proposed fix is to flush the handshakes objects whenever new gadgets call gadgets.rpc.setupReceiver is called to make sure the container side register the child iframe info to the flash component.
This addresses bug SHINDIG-1678.
https://issues.apache.org/jira/browse/SHINDIG-1678
Diffs
-----
trunk/features/src/main/javascript/features/rpc/flash.transport.js 1233272
Diff: https://reviews.apache.org/r/3566/diff
Testing
-------
Running multiple gadgets in common container in IE7
Thanks,
Henry
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1678) The flash transport to support RPc
for IE7 has problem with multiple gadgets in a single container
Posted by "Henry Saputra (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra updated SHINDIG-1678:
-----------------------------------
Description:
The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
was:
The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
The flash component act as singleton to the transport ready() function is only called once even though multiple gadget calls gadgets.rpc.setupReceiver()
> The flash transport to support RPc for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1678) The flash transport to support
RPC for IE7 has problem with multiple gadgets in a single container
Posted by "Henry Saputra (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189900#comment-13189900 ]
Henry Saputra commented on SHINDIG-1678:
----------------------------------------
Add proposed fix review: https://reviews.apache.org/r/3566/
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1678) The flash transport to support
RPC for IE7 has problem with multiple gadgets in a single container
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189940#comment-13189940 ]
jiraposter@reviews.apache.org commented on SHINDIG-1678:
--------------------------------------------------------
bq. On 2012-01-20 17:24:54, Stanton Sievers wrote:
bq. > LGTM. Thanks Henry! To clarify, is this only an issue in IE7 or would it be an issue with any browser that uses the flash transport? Theoretically you could force RPC to always use flash, regardless of the browser, by setting rpctx=flash in the query params. See rpc.js#getTransport()
You were right, this is happening when using flash transport not just IE7.
bq. On 2012-01-20 17:24:54, Stanton Sievers wrote:
bq. > trunk/features/src/main/javascript/features/rpc/flash.transport.js, line 47
bq. > <https://reviews.apache.org/r/3566/diff/1/?file=70156#file70156line47>
bq. >
bq. > Out of curiosity, how did you come up with this number?
It was a number I used to make sure the timeout is not too small because when container register a gadget via call to gadgets.rpc.setupReceiver() it will call flushHandshakes function.
So the timeout interval to call flushHandshakes() function is only needed when relayHandle['setup'] somehow is not ready when flushHandshakes() is called.
- Henry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3566/#review4496
-----------------------------------------------------------
On 2012-01-20 16:53:37, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3566/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-20 16:53:37)
bq.
bq.
bq. Review request for shindig and johnfargo.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container" https://issues.apache.org/jira/browse/SHINDIG-1678 for detail description about the review.
bq.
bq. Proposed fix is to flush the handshakes objects whenever new gadgets call gadgets.rpc.setupReceiver is called to make sure the container side register the child iframe info to the flash component.
bq.
bq.
bq. This addresses bug SHINDIG-1678.
bq. https://issues.apache.org/jira/browse/SHINDIG-1678
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/features/src/main/javascript/features/rpc/flash.transport.js 1233272
bq.
bq. Diff: https://reviews.apache.org/r/3566/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Running multiple gadgets in common container in IE7
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1678) The flash transport to support
RPC for IE7 has problem with multiple gadgets in a single container
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193495#comment-13193495 ]
jiraposter@reviews.apache.org commented on SHINDIG-1678:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3566/#review4617
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2012-01-25 19:57:26, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3566/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-25 19:57:26)
bq.
bq.
bq. Review request for shindig and johnfargo.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container" https://issues.apache.org/jira/browse/SHINDIG-1678 for detail description about the review.
bq.
bq. Proposed fix is to flush the handshakes objects whenever new gadgets call gadgets.rpc.setupReceiver is called to make sure the container side register the child iframe info to the flash component.
bq.
bq.
bq. This addresses bug SHINDIG-1678.
bq. https://issues.apache.org/jira/browse/SHINDIG-1678
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/features/src/main/javascript/features/rpc/flash.transport.js 1234681
bq.
bq. Diff: https://reviews.apache.org/r/3566/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Running multiple gadgets in common container in IE7
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
> Fix For: 3.0.0
>
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1678) The flash transport to support RPC
for IE7 has problem with multiple gadgets in a single container
Posted by "Henry Saputra (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra updated SHINDIG-1678:
-----------------------------------
Summary: The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container (was: The flash transport to support RPc for IE7 has problem with multiple gadgets in a single container)
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1678) The flash transport to support RPC
for IE7 has problem with multiple gadgets in a single container
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1678.
---------------------------------
part of 2.5.0-beta1 release.
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 2.5.0-beta1
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
> Fix For: 2.5.0-beta1
>
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1678) The flash transport to support
RPC for IE7 has problem with multiple gadgets in a single container
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193263#comment-13193263 ]
jiraposter@reviews.apache.org commented on SHINDIG-1678:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3566/
-----------------------------------------------------------
(Updated 2012-01-25 19:57:26.438920)
Review request for shindig and johnfargo.
Changes
-------
Need to move call to flushHandshakes() into the setup() function. The reason is that the relayLoader will not be called if relayHandle has been set.
Summary
-------
See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container" https://issues.apache.org/jira/browse/SHINDIG-1678 for detail description about the review.
Proposed fix is to flush the handshakes objects whenever new gadgets call gadgets.rpc.setupReceiver is called to make sure the container side register the child iframe info to the flash component.
This addresses bug SHINDIG-1678.
https://issues.apache.org/jira/browse/SHINDIG-1678
Diffs (updated)
-----
trunk/features/src/main/javascript/features/rpc/flash.transport.js 1234681
Diff: https://reviews.apache.org/r/3566/diff
Testing
-------
Running multiple gadgets in common container in IE7
Thanks,
Henry
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1678) The flash transport to support RPC
for IE7 has problem with multiple gadgets in a single container
Posted by "Henry Saputra (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Saputra resolved SHINDIG-1678.
------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Committed revision 1235983.
> The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container
> --------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1678
> URL: https://issues.apache.org/jira/browse/SHINDIG-1678
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Labels: ie7, rpc
> Fix For: 3.0.0
>
>
> The flash rpc transport to support ie7 does not work properly for multiple gadgets in a single container. The function flushHandshakes in flash.transport.js only called by ready() function which only be called once by the flash component after it initialized itself.
> The flash component act as singleton to make sure the main function only called once for a page. The transport ready() function which called at the end of the main function of the actionscript file hence only called once even though multiple gadget call gadgets.rpc.setupReceiver().
> So if a second gadget is in the same container, the flushHandshakes() will never be called to setup that gadget iframe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira