You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by GitBox <gi...@apache.org> on 2018/09/19 03:24:37 UTC

[GitHub] luguosheng1314 closed pull request #238: KYLIN-3565 User login error message is inaccurate

luguosheng1314 closed pull request #238: KYLIN-3565 User login error message is inaccurate
URL: https://github.com/apache/kylin/pull/238
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/webapp/app/js/controllers/auth.js b/webapp/app/js/controllers/auth.js
index 6e5fa30d56..949093ee4e 100644
--- a/webapp/app/js/controllers/auth.js
+++ b/webapp/app/js/controllers/auth.js
@@ -36,7 +36,9 @@ KylinApp.controller('LoginCtrl', function ($scope, $rootScope, $location, $base6
       $location.path(UserService.getHomePage());
     }, function (error) {
       $scope.loading = false;
-      $scope.error = "Unable to login, please check your username/password.";
+      $scope.error = error.status < 500
+        ? "Unable to login, please check your username/password."
+        : "System error, please contact your administrator.";
     });
   };
 });


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services