You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/06/18 07:22:24 UTC
[GitHub] [skywalking-python] sungitly opened a new pull request #20: Add werkzeug support to sw_http_server plugin
sungitly opened a new pull request #20:
URL: https://github.com/apache/skywalking-python/pull/20
Werkzeug is widely used by python web community. Currently sw_http_server plugin doesn't support instrumenting werkzeug based python web server becasue the do_method won't be invoked at all.
See
https://github.com/pallets/werkzeug/blob/fc999a6262c847ad185ea3ffe0cc6f2e915a867a/src/werkzeug/serving.py#L328
When werkzeug WSGI handler is detected instead of BaseHTTPRequestHandler, wrap run_wsgi to add Skywalking instrument code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #20: Add werkzeug support to sw_http_server plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #20:
URL: https://github.com/apache/skywalking-python/pull/20#issuecomment-645891498
@sungitly thanks for your contribution, can you please update the corresponding test please? If you have any question on how to do that, please ping me for help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #20: Add werkzeug support to sw_http_server plugin
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #20:
URL: https://github.com/apache/skywalking-python/pull/20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org