[GitHub] [pinot] walterddr commented on a diff in pull request #10472: 10415: Type match between resultType and function's dataType

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10472:
URL: https://github.com/apache/pinot/pull/10472#discussion_r1152692167


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FunctionOperand.java:
##########
@@ -52,6 +52,9 @@ public FunctionOperand(RexExpression.FunctionCall functionCall, DataSchema dataS
     _resultName = computeColumnName(functionCall.getFunctionName(), _childOperandList);
     // TODO: Check type match between functionCall's data type and result type.
     _resultType = FunctionUtils.getColumnDataType(_functionInvoker.getResultClass());
+
+    boolean isTypeMatched = functionCall.getDataType() == _resultType.toDataType();
+    Preconditions.checkState(isTypeMatched, "Mismatch function data type and result type");

Review Comment:
   thank you will do. i also asked for more examples from @ankitsultana in the original issue. let's wait for a bit and add more test cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org