You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Vincent Massol (JIRA)" <ji...@codehaus.org> on 2007/07/09 11:45:13 UTC

[jira] Created: (MNG-3097) Build extension not working if not placed in the pom.xml where a reactor build is initiated

Build extension not working if not placed in the pom.xml where a reactor build is initiated
-------------------------------------------------------------------------------------------

                 Key: MNG-3097
                 URL: http://jira.codehaus.org/browse/MNG-3097
             Project: Maven 2
          Issue Type: Bug
    Affects Versions: 2.1
            Reporter: Vincent Massol


If I have a multi module build and if the build extension is located in one of the sub modules being built it's ignored. It has to be placed in the pom.xml where the multi module build is initiated to be taken into account.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3097) Build extension not working if not placed in the pom.xml where a reactor build is initiated

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112847 ] 

John Casey commented on MNG-3097:
---------------------------------

This has never worked, to my knowledge. Or at least, I can't see how we could guarantee that any but a handful of things in that extension would be usable in that build. This is because the lifecycle executor (and, in 2.1, the extension scanner) pushes extensions into the core realm. When it does this, I don't think it's particularly sensitive to artfiacts that come from within the existing build process. I haven't looked back at the 2.0.x code on this yet, but I'm pretty sure active artifacts are not in use, and that extensions are all loaded up front when the lifecycle executor runs...which means that if the extension project hasn't been built yet, and no previous artifact for that extension is in the repository, it won't load.

Vincent, are you certain this works in 2.0.7?

> Build extension not working if not placed in the pom.xml where a reactor build is initiated
> -------------------------------------------------------------------------------------------
>
>                 Key: MNG-3097
>                 URL: http://jira.codehaus.org/browse/MNG-3097
>             Project: Maven 2
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>            Reporter: Vincent Massol
>             Fix For: 2.1-alpha-1
>
>
> If I have a multi module build and if the build extension is located in one of the sub modules being built it's ignored. It has to be placed in the pom.xml where the multi module build is initiated to be taken into account.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3097) Build extension not working if not placed in the pom.xml where a reactor build is initiated

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MNG-3097:
------------------------------

    Affects Version/s:     (was: 2.1)
                       2.1-alpha-1
        Fix Version/s: 2.1-alpha-1

assuming this is a regression in 2.1-alpha-1? Can you provide more details?

> Build extension not working if not placed in the pom.xml where a reactor build is initiated
> -------------------------------------------------------------------------------------------
>
>                 Key: MNG-3097
>                 URL: http://jira.codehaus.org/browse/MNG-3097
>             Project: Maven 2
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>            Reporter: Vincent Massol
>             Fix For: 2.1-alpha-1
>
>
> If I have a multi module build and if the build extension is located in one of the sub modules being built it's ignored. It has to be placed in the pom.xml where the multi module build is initiated to be taken into account.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MNG-3097) Build extension not working if not placed in the pom.xml where a reactor build is initiated

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Casey updated MNG-3097:
----------------------------

    Affects Version/s: 2.0.x
                       2.0.4
                       2.0.5
                       2.0.6
                       2.0.7
        Fix Version/s:     (was: 2.1-alpha-1)
                       2.x

I'm not sure we'll ever have an elegant way to solve this problem. Part of the snag is that extensions by definition change the way the build runs. If the extension is meant to be part of the build, then we have the potential for a chicken-and-egg scenario where the extension is built and then modifies the build to exclude its own module (in the case of a profile activator, for example).

In any case, this is not a regression, so I'm moving it a little further out so we can do some discussion and design work.

> Build extension not working if not placed in the pom.xml where a reactor build is initiated
> -------------------------------------------------------------------------------------------
>
>                 Key: MNG-3097
>                 URL: http://jira.codehaus.org/browse/MNG-3097
>             Project: Maven 2
>          Issue Type: Bug
>    Affects Versions: 2.0.4, 2.0.5, 2.0.6, 2.0.7, 2.0.x, 2.1-alpha-1
>            Reporter: Vincent Massol
>             Fix For: 2.x
>
>
> If I have a multi module build and if the build extension is located in one of the sub modules being built it's ignored. It has to be placed in the pom.xml where the multi module build is initiated to be taken into account.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-3097) Build extension not working if not placed in the pom.xml where a reactor build is initiated

Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-3097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_112848 ] 

Vincent Massol commented on MNG-3097:
-------------------------------------

John/Brett,

This has never worked in 2.0.7 to my knowledge. I guess the "affects version" should be 2.0.7 then and not alpha-1.

Thanks
-Vincent

> Build extension not working if not placed in the pom.xml where a reactor build is initiated
> -------------------------------------------------------------------------------------------
>
>                 Key: MNG-3097
>                 URL: http://jira.codehaus.org/browse/MNG-3097
>             Project: Maven 2
>          Issue Type: Bug
>    Affects Versions: 2.1-alpha-1
>            Reporter: Vincent Massol
>             Fix For: 2.1-alpha-1
>
>
> If I have a multi module build and if the build extension is located in one of the sub modules being built it's ignored. It has to be placed in the pom.xml where the multi module build is initiated to be taken into account.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira