[DIGESTER-AT] FromAnnotationsRuleSet could be immutable?

[sebb <se...@gmail.com>]

As far as I can tell, FromAnnotationsRuleSet is currently the only
mutable class in the annotations packages, and that mutability is only
because of the setNameSpaceURI() method.

Would it be possible to make the URI a constructor parameter instead?

If not, perhaps consider whether to make the String field volatile.
This would make all the classes thread-safe.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [DIGESTER-AT] FromAnnotationsRuleSet could be immutable?

[Simone Tripodi <si...@gmail.com>]

Hi Sebb,
your suggestions are like water in the middle of the Sahara, thanks a *lot*,
this is a very god catch! Very very appreciated!!!
I'm going to make it volatile, thanks again :)
Simo

http://people.apache.org/~simonetripodi/


On Wed, Jan 27, 2010 at 6:24 PM, sebb <se...@gmail.com> wrote:

> As far as I can tell, FromAnnotationsRuleSet is currently the only
> mutable class in the annotations packages, and that mutability is only
> because of the setNameSpaceURI() method.
>
> Would it be possible to make the URI a constructor parameter instead?
>
> If not, perhaps consider whether to make the String field volatile.
> This would make all the classes thread-safe.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>