You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2019/11/23 04:41:33 UTC

[GitHub] [sling-org-apache-sling-models-impl] paul-bjorkstrand commented on issue #18: SLING-8858 - Added NPE check

paul-bjorkstrand commented on issue #18: SLING-8858 - Added NPE check
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/18#issuecomment-557766580
 
 
   Looks liek a good quick fix. The only thing I would say is to add a test for this case. I will note that writing a test for the issue this originally fixed [was a bit painful][link to test class].
   
   @klcodanr, what do you think about the test-case idea? It may require splitting out the cache from this class so it can be mocked (to avoid needing to exhaust memory just to test that an NPE doesn't occur). Do you have any other ideas on how to test this?
   
   [link to test class]: https://github.com/apache/sling-org-apache-sling-models-impl/pull/9/files#diff-47140f95ccc32e82c278844f4aee6161

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services