You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/13 02:46:30 UTC

[GitHub] [kafka] showuon commented on a change in pull request #11208: MINOR: Refactored BrokerHeartbeatManager::findOneStaleBroker to not use

showuon commented on a change in pull request #11208:
URL: https://github.com/apache/kafka/pull/11208#discussion_r688206957



##########
File path: metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java
##########
@@ -200,6 +200,14 @@ void registerBrokers(Integer... brokerIds) throws Exception {
             }
         }
 
+        Set<Integer> fencedBrokerIds() {
+            return clusterControl.brokerRegistrations().values()

Review comment:
       Since it's put inside test class now, we cat declare it as `private`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org