You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/13 09:50:26 UTC
[GitHub] [spark] Ngone51 edited a comment on issue #28195:
[SPARK-31425][SQL][CORE] UnsafeKVExternalSorter should also respect
UnsafeAlignedOffset
Ngone51 edited a comment on issue #28195: [SPARK-31425][SQL][CORE] UnsafeKVExternalSorter should also respect UnsafeAlignedOffset
URL: https://github.com/apache/spark/pull/28195#issuecomment-612833274
> can we have a test?
yet, I updated `HashAggregationQueryWithControlledFallbackSuite` to test both 4 and 8 `uaoSize`, which actually can fail with `uaoSize = 8`.
Seems better if we could update all those related tests to test both as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org