You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2019/02/09 21:02:00 UTC
[jira] [Resolved] (ARROW-4264) [C++] Document why DCHECKs are used
in kernels
[ https://issues.apache.org/jira/browse/ARROW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wes McKinney resolved ARROW-4264.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.13.0
Issue resolved by pull request 3588
[https://github.com/apache/arrow/pull/3588]
> [C++] Document why DCHECKs are used in kernels
> ----------------------------------------------
>
> Key: ARROW-4264
> URL: https://issues.apache.org/jira/browse/ARROW-4264
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: Micah Kornfield
> Assignee: Micah Kornfield
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.13.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> DCHECKs seem to be used where Status::Invalid might be considered more appropriate (so programs don't crash). See conversation on [https://github.com/apache/arrow/pull/3287/files]
> based on conversation on this Jira and on the CL it seems DCHECKS are in fact desired but we should document appropriate use for them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)