You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/16 14:56:00 UTC
[GitHub] [arrow] xhochy opened a new pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
xhochy opened a new pull request #7452:
URL: https://github.com/apache/arrow/pull/7452
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-647688900
@maartenbreddels Feel free to rebase again, this patch is ready for a merge.
@wesm Should we merge this as-is or is delay it until @maartenbreddels branch is ready?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] maartenbreddels commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
maartenbreddels commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-645216695
Would also be good to be sure we're not switching to unilib https://github.com/apache/arrow/pull/7449#issuecomment-645023981 before merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-647834442
TODO:
* Need the `UTF8PROC_STATIC` definition with bundled utf8proc
* Need to add include path for `utf8proc.h`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-647763853
@xhochy I'm fine with merging this -- it's a non-mandatory dependency right (sorry have not reviewed the patch yet and the PR description does not say)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-649098754
Once the utf8_lower/utf8_upper patch lands I am going to make utf8proc not mandatory. See ARROW-9220.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on a change in pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on a change in pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#discussion_r442159234
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+if(UTF8PROC_ROOT)
+ find_library(
+ UTF8PROC_LIB
+ NAMES utf8proc
+ "${CMAKE_SHARED_LIBRARY_PREFIX}utf8proc${CMAKE_SHARED_LIBRARY_SUFFIX}"
+ PATHS ${UTF8PROC_ROOT}
+ PATH_SUFFIXES ${LIB_PATH_SUFFIXES}
+ NO_DEFAULT_PATH)
+ find_path(UTF8PROC_INCLUDE_DIR
+ NAMES utf8proc.h
+ PATHS ${UTF8PROC_ROOT}
+ NO_DEFAULT_PATH
+ PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES})
+
+else()
+ find_library(
+ UTF8PROC_LIB
+ NAMES utf8proc
+ "${CMAKE_SHARED_LIBRARY_PREFIX}utf8proc${CMAKE_SHARED_LIBRARY_SUFFIX}"
+ PATH_SUFFIXES ${LIB_PATH_SUFFIXES})
+ find_path(UTF8PROC_INCLUDE_DIR NAMES utf8proc.h PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES})
+endif()
+
+find_package_handle_standard_args(utf8proc REQUIRED_VARS UTF8PROC_LIB UTF8PROC_INCLUDE_DIR)
+
+# CMake 3.2 does uppercase the FOUND variable
+if(UTF8PROC_FOUND OR utf8proc_FOUND)
+ set(utf8proc_FOUND TRUE)
+ add_library(utf8proc::utf8proc UNKNOWN IMPORTED)
Review comment:
We don't know here whether resolved the static or shared version of `utf8proc`. But we don't actually use this information later on, so we don't need to write code to determine it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646784414
@github-actions crossbow submit -g wheel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646783738
Valgrind failure looks totally unrelated: https://github.com/ursa-labs/crossbow/runs/788860352?check_suite_focus=true
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646813835
Revision: f1609e6dfe0dee96f2794edc77749cf62cc07f21
Submitted crossbow builds: [ursa-labs/crossbow @ actions-344](https://github.com/ursa-labs/crossbow/branches/all?query=actions-344)
|Task|Status|
|----|------|
|test-debian-10-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-344-circle-test-debian-10-cpp)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646594306
```
No such command 'run'.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646747888
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
kou closed pull request #7452:
URL: https://github.com/apache/arrow/pull/7452
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-645216102
> @xhochy I do not see utf8proc being built here:
> https://ci.ursalabs.org/#/builders/84/builds/9077/steps/4/logs/stdio
Was an upper- vs lowercase issue. Now it errors out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-644818480
cc @wesm @maartenbreddels
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-647571012
Revision: 5ab75c48ef009fcee7ef602d39c2327d629d080a
Submitted crossbow builds: [ursa-labs/crossbow @ actions-357](https://github.com/ursa-labs/crossbow/branches/all?query=actions-357)
|Task|Status|
|----|------|
|conda-clean|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-clean)|
|conda-linux-gcc-py36-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-linux-gcc-py36-cpu)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-linux-gcc-py37-cpu)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-linux-gcc-py38-cuda)|
|conda-osx-clang-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-osx-clang-py36)|
|conda-osx-clang-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-osx-clang-py37)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-osx-clang-py38)|
|conda-win-vs2015-py36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-win-vs2015-py36)|
|conda-win-vs2015-py37|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-win-vs2015-py37)|
|conda-win-vs2015-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-357-azure-conda-win-vs2015-py38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646868366
Revision: 7883277a36f5c5b274eff2f42de5a6c28146d7c7
Submitted crossbow builds: [ursa-labs/crossbow @ actions-346](https://github.com/ursa-labs/crossbow/branches/all?query=actions-346)
|Task|Status|
|----|------|
|centos-6-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-346-github-centos-6-amd64)|
|centos-7-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-7-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-346-github-centos-7-amd64)|
|centos-8-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-8-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-346-github-centos-8-amd64)|
|debian-buster-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-346-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|debian-stretch-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-346-github-debian-stretch-amd64)|
|debian-stretch-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-bionic-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-346-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-eoan-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-346-github-ubuntu-eoan-amd64)|
|ubuntu-eoan-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-346-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-xenial-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-346-github-ubuntu-xenial-amd64)|
|ubuntu-xenial-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-647569437
@github-actions crossbow submit conda-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-644818118
https://issues.apache.org/jira/browse/ARROW-8961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-644920493
@xhochy I do not see utf8proc being built here:
https://ci.ursalabs.org/#/builders/84/builds/9077/steps/4/logs/stdio
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646785722
Revision: e98614e4a69ade342ec6bae3c2641117ecd1afdf
Submitted crossbow builds: [ursa-labs/crossbow @ actions-342](https://github.com/ursa-labs/crossbow/branches/all?query=actions-342)
|Task|Status|
|----|------|
|wheel-manylinux1-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux1-cp35m)|
|wheel-manylinux1-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux1-cp36m)|
|wheel-manylinux1-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux1-cp37m)|
|wheel-manylinux1-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux1-cp38)|
|wheel-manylinux2010-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux2010-cp35m)|
|wheel-manylinux2010-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux2010-cp36m)|
|wheel-manylinux2010-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux2010-cp37m)|
|wheel-manylinux2010-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux2010-cp38)|
|wheel-manylinux2014-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux2014-cp35m)|
|wheel-manylinux2014-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux2014-cp36m)|
|wheel-manylinux2014-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux2014-cp37m)|
|wheel-manylinux2014-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-342-azure-wheel-manylinux2014-cp38)|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#discussion_r443047872
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -493,6 +500,16 @@ else()
)
endif()
+if(DEFINED ENV{UTF8PROC_SOURCE_URL})
+ set(UTF8PROC_SOURCE_URL "$ENV{UTF8PROC_SOURCE_URL}")
+else()
+ set_urls(
+ UTF8PROC_SOURCE_URL
+ "https://github.com/JuliaStrings/utf8proc/archive/${ARROW_UTF8PROC_BUILD_VERSION}.tar.gz"
+ "https://github.com/ursa-labs/thirdparty/releases/download/latest/utf8proc-${ARROW_UTF8PROC_BUILD_VERSION}.tar.gz"
Review comment:
This doesn't exist.
It seems that we don't need this backup URL. If github.com is down, both of them are failed.
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+if(UTF8PROC_ROOT)
Review comment:
Could you use `utf8proc_ROOT` because we use `utf8proc` for package name?
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2013,6 +2030,47 @@ if(ARROW_WITH_BZ2)
include_directories(SYSTEM "${BZIP2_INCLUDE_DIR}")
endif()
+macro(build_utf8proc)
+ message(STATUS "Building utf8proc from source")
+ set(UTF8PROC_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/utf8proc_ep-install")
+ if(MSVC)
+ set(UTF8PROC_STATIC_LIB "${UTF8PROC_PREFIX}/lib/utf8proc_static.lib")
+ else()
+ set(
+ UTF8PROC_STATIC_LIB
+ "${UTF8PROC_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}utf8proc${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ )
+ endif()
+
+ set(UTF8PROC_CMAKE_ARGS
+ ${EP_COMMON_TOOLCHAIN}
+ "-DCMAKE_INSTALL_PREFIX=${UTF8PROC_PREFIX}"
+ -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
+ -DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR}
Review comment:
Could you use `lib` if we use `lib` in `UTF8PROC_STATIC_LIB`?
Or could you use `${CMAKE_INSTALL_LIBDIR}` in `UTF8PROC_STATIC_LIB`?
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -493,6 +500,16 @@ else()
)
endif()
+if(DEFINED ENV{UTF8PROC_SOURCE_URL})
Review comment:
Could you use `ARROW_UTF8PROC_URL` like other packages?
(Could you also fix `BZIP2_SOURCE_URL`?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646594021
@github-actions crossbow submit -g cpp -g wheel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-649085709
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646871541
@github-actions crossbow submit centos-8-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646872055
Revision: 3ef68af4b928d3fadfa6aa4df82ecbba02113782
Submitted crossbow builds: [ursa-labs/crossbow @ actions-347](https://github.com/ursa-labs/crossbow/branches/all?query=actions-347)
|Task|Status|
|----|------|
|centos-8-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-8-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-347-github-centos-8-amd64)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-645217393
> Would also be good to be sure we're not switching to unilib [#7449 (comment)](https://github.com/apache/arrow/pull/7449#issuecomment-645023981) before merging this.
It will be nearly the same PR. If this one works, we can replace all `utf8proc` occurences with `unilib`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-647566604
@github-actions crossbow submit -g conda-*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-647555249
@github-actions crossbow submit -g linux conda
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646905286
+1 for Linux packages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646867851
@github-actions crossbow submit -g linux
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646533368
@maartenbreddels This is passing now, feel free to rebase again.
@pitrou @kou @kszucs Any suggestions for Crossbow jobs I should run here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646594741
Revision: e98614e4a69ade342ec6bae3c2641117ecd1afdf
Submitted crossbow builds: [ursa-labs/crossbow @ actions-337](https://github.com/ursa-labs/crossbow/branches/all?query=actions-337)
|Task|Status|
|----|------|
|test-conda-cpp|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-337-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-337-github-test-conda-cpp-valgrind)|
|test-debian-10-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-337-circle-test-debian-10-cpp)|
|test-fedora-32-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-337-circle-test-fedora-32-cpp)|
|test-ubuntu-16.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-337-circle-test-ubuntu-16.04-cpp)|
|test-ubuntu-18.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-337-circle-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-cmake32|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-337-circle-test-ubuntu-18.04-cpp-cmake32)|
|test-ubuntu-18.04-cpp-release|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-337-circle-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-337-circle-test-ubuntu-18.04-cpp-static)|
|wheel-manylinux1-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux1-cp35m)|
|wheel-manylinux1-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux1-cp36m)|
|wheel-manylinux1-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux1-cp37m)|
|wheel-manylinux1-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux1-cp38)|
|wheel-manylinux2010-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux2010-cp35m)|
|wheel-manylinux2010-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux2010-cp36m)|
|wheel-manylinux2010-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux2010-cp37m)|
|wheel-manylinux2010-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux2010-cp38)|
|wheel-manylinux2014-cp35m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux2014-cp35m)|
|wheel-manylinux2014-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux2014-cp36m)|
|wheel-manylinux2014-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux2014-cp37m)|
|wheel-manylinux2014-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-337-azure-wheel-manylinux2014-cp38)|
|wheel-osx-cp35m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-win-cp35m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp36m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp37m|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
|wheel-win-cp38|[](https://ci.appveyor.com/project/ursa-labs/crossbow/history)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646749663
Revision: e98614e4a69ade342ec6bae3c2641117ecd1afdf
Submitted crossbow builds: [ursa-labs/crossbow @ actions-340](https://github.com/ursa-labs/crossbow/branches/all?query=actions-340)
|Task|Status|
|----|------|
|test-conda-cpp|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-340-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-340-github-test-conda-cpp-valgrind)|
|test-debian-10-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-340-circle-test-debian-10-cpp)|
|test-fedora-32-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-340-circle-test-fedora-32-cpp)|
|test-ubuntu-16.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-340-circle-test-ubuntu-16.04-cpp)|
|test-ubuntu-18.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-340-circle-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-cmake32|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-340-circle-test-ubuntu-18.04-cpp-cmake32)|
|test-ubuntu-18.04-cpp-release|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-340-circle-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-340-circle-test-ubuntu-18.04-cpp-static)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646593973
@github-actions crossbow run -g cpp -g wheel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-646813324
@github-actions crossbow submit test-debian-10-cpp
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#discussion_r442127449
##########
File path: cpp/cmake_modules/Findutf8proc.cmake
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+if(UTF8PROC_ROOT)
+ find_library(
+ UTF8PROC_LIB
+ NAMES utf8proc
+ "${CMAKE_SHARED_LIBRARY_PREFIX}utf8proc${CMAKE_SHARED_LIBRARY_SUFFIX}"
+ PATHS ${UTF8PROC_ROOT}
+ PATH_SUFFIXES ${LIB_PATH_SUFFIXES}
+ NO_DEFAULT_PATH)
+ find_path(UTF8PROC_INCLUDE_DIR
+ NAMES utf8proc.h
+ PATHS ${UTF8PROC_ROOT}
+ NO_DEFAULT_PATH
+ PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES})
+
+else()
+ find_library(
+ UTF8PROC_LIB
+ NAMES utf8proc
+ "${CMAKE_SHARED_LIBRARY_PREFIX}utf8proc${CMAKE_SHARED_LIBRARY_SUFFIX}"
+ PATH_SUFFIXES ${LIB_PATH_SUFFIXES})
+ find_path(UTF8PROC_INCLUDE_DIR NAMES utf8proc.h PATH_SUFFIXES ${INCLUDE_PATH_SUFFIXES})
+endif()
+
+find_package_handle_standard_args(utf8proc REQUIRED_VARS UTF8PROC_LIB UTF8PROC_INCLUDE_DIR)
+
+# CMake 3.2 does uppercase the FOUND variable
+if(UTF8PROC_FOUND OR utf8proc_FOUND)
+ set(utf8proc_FOUND TRUE)
+ add_library(utf8proc::utf8proc UNKNOWN IMPORTED)
Review comment:
Why "UNKNOWN"?
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -49,6 +49,7 @@ ARROW_THRIFT_BUILD_VERSION=0.12.0
ARROW_THRIFT_BUILD_MD5_CHECKSUM=3deebbb4d1ca77dd9c9e009a1ea02183
ARROW_ZLIB_BUILD_VERSION=1.2.11
ARROW_ZSTD_BUILD_VERSION=v1.4.5
+ARROW_UTF8PROC_BUILD_VERSION=v2.5.0
Review comment:
Can you keep this file in alphabetical order?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-645370067
Appears that unilib is a no go. I'm not a fan of one-developer projects anyway
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-645548108
@ursabot build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-645213214
> @xhochy do you want me to rebase #7449 on this? So we can see if it's all working?
Yes, that would make sense. Might also show me better what the issue is that @pitrou pointed out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] maartenbreddels commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
maartenbreddels commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-644951837
@xhochy do you want me to rebase https://github.com/apache/arrow/pull/7449 on this? So we can see if it's all working?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7452: ARROW-8961: [C++] Add utf8proc library to toolchain
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7452:
URL: https://github.com/apache/arrow/pull/7452#issuecomment-647560430
Revision: 5ab75c48ef009fcee7ef602d39c2327d629d080a
Submitted crossbow builds: [ursa-labs/crossbow @ actions-356](https://github.com/ursa-labs/crossbow/branches/all?query=actions-356)
|Task|Status|
|----|------|
|centos-6-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-356-github-centos-6-amd64)|
|centos-7-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-7-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-356-github-centos-7-amd64)|
|centos-8-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-8-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-356-github-centos-8-amd64)|
|debian-buster-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-356-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|debian-stretch-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-356-github-debian-stretch-amd64)|
|debian-stretch-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-bionic-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-356-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-eoan-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-356-github-ubuntu-eoan-amd64)|
|ubuntu-eoan-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-356-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-xenial-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-356-github-ubuntu-xenial-amd64)|
|ubuntu-xenial-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org