You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/30 10:35:53 UTC

[GitHub] [airflow] ashb commented on a change in pull request #5345: AIRFLOW-4594 Pod state might be different from task state. So don't c…

ashb commented on a change in pull request #5345: AIRFLOW-4594 Pod state might be different from task state. So don't c…
URL: https://github.com/apache/airflow/pull/5345#discussion_r288940735
 
 

 ##########
 File path: airflow/executors/kubernetes_executor.py
 ##########
 @@ -364,7 +364,7 @@ def process_status(self, pod_id, status, labels, resource_version):
             self.log.info('Event: %s Pending', pod_id)
         elif status == 'Failed':
             self.log.info('Event: %s Failed', pod_id)
-            self.watcher_queue.put((pod_id, State.FAILED, labels, resource_version))
 
 Review comment:
   I think this is too simplistic and will miss cases where the pod hard fails and hasn't updated the state (i.e. if it gets OOM killed) - likely this would end up leaving tasks in the running state.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services