[GitHub] [activemq-artemis] gemmellr commented on pull request #3568: ARTEMIS-3200 - remove braces from the belt and braces fix in ARTEMIS-…

[GitBox <gi...@apache.org>]

gemmellr commented on pull request #3568:
URL: https://github.com/apache/activemq-artemis/pull/3568#issuecomment-834257058


   Presumably the registration is meant for cases the close call to clearLargeMessage() doesnt happen, e.g when the session is closed without consumer close, or the connection drops etc...the latter is actually mentioned directly by Clebert on the original ARTEMIS-2712 JIRA, even though I had raised it to report a very separate issue with prior code changes not handling explicitly aborted deliveries and causing corruption of a subsequent delivery.
   
   Actually, looking over the code now, it seems the close(ErrorCondition) method in ProtonAbstractReceiver that calls the clearLargeMessage() cleanup method doesnt look to be used at all. It seems like the code only calls that method for consumers (i.e ProtonServerSenderContext) e.g. when a queue is deleted, in AMQPSessionCallback.disconnect(ServerConsumer, SimpleString). If thats the case, it would seem such outstanding/incomplete 'large' file cleanup wont be occurring at all during consumer closure, and actually only later during session cleanup due to the registration that this PR is looking to remove?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org