You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "Jian Feng (Jira)" <ji...@apache.org> on 2022/07/18 08:29:00 UTC
[jira] [Updated] (HUDI-4413) Make the return value of LockProvider's tryLock method more reasonable
[ https://issues.apache.org/jira/browse/HUDI-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jian Feng updated HUDI-4413:
----------------------------
Description:
For now, zk lock provider and hive lock provider never return false when tryLock, hence it will always return an Exception, Why can't it return false? is it make sense to always return Exception? I feel maybe we need to make sure the behavior is properly first
if want to return false or return HoodieLockException or return InterruptedException, should mean something
eg: if lockprovider returns a IllegalArgumentException we don't need to retry in LockManager since it will always illegal
was:
For now, zk lock provider and hive lock provider never return false when tryLock, hence it will always return an Exception, Why can't it return false? is it make sense to always return Exception? I feel maybe we need to make sure the behavior is properly first
if want to return false or return HoodieLockException or return InterruptedException, should mean something
eg: if lockprovider returns a IllegalArgumentException we don't need to retry since it will always illegal
> Make the return value of LockProvider's tryLock method more reasonable
> ----------------------------------------------------------------------
>
> Key: HUDI-4413
> URL: https://issues.apache.org/jira/browse/HUDI-4413
> Project: Apache Hudi
> Issue Type: Improvement
> Reporter: Jian Feng
> Priority: Major
>
> For now, zk lock provider and hive lock provider never return false when tryLock, hence it will always return an Exception, Why can't it return false? is it make sense to always return Exception? I feel maybe we need to make sure the behavior is properly first
> if want to return false or return HoodieLockException or return InterruptedException, should mean something
> eg: if lockprovider returns a IllegalArgumentException we don't need to retry in LockManager since it will always illegal
--
This message was sent by Atlassian Jira
(v8.20.10#820010)