You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/01/23 20:14:02 UTC

Re: Review Request 17252: AMBARI-4394 : Temporal Host metrics can get overwritten.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17252/
-----------------------------------------------------------

(Updated Jan. 23, 2014, 7:14 p.m.)


Review request for Ambari, Mahadev Konar and Nate Cole.


Bugs: AMBARI-4394
    https://issues.apache.org/jira/browse/AMBARI-4394


Repository: ambari


Description
-------

If the response for Host metrics from rrd.py (Ganglia metrics) contains an empty response for a Ganglia cluster type, the empty response may overwrite valid metrics.  For example, if a host has only slave components it may still produce an empty rrd file for HDPNameNode.  If it exists, the empty results may overwrite the valid results from the HDPSlaves rrd files.   


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProvider.java 1914875 
  ambari-server/src/test/java/org/apache/ambari/server/controller/ganglia/GangliaPropertyProviderTest.java f981e98 
  ambari-server/src/test/resources/host_temporal_ganglia_data.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/17252/diff/


Testing
-------

New test : 
GangliaPropertyProviderTest.testPopulateResources_checkHostComponent()


All unit tests pass : 

Results :

Tests run: 1277, Failures: 0, Errors: 0, Skipped: 8


Thanks,

Tom Beerbower