You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/26 05:48:51 UTC
[GitHub] [flink] zhijiangW opened a new pull request #11219:
[FLINK-16257][network] Remove useless ResultPartitionID from AddCredit
message
zhijiangW opened a new pull request #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219
## What is the purpose of the change
The `ResultPartitionID` in AddCredit message is never used on upstream side, so we can remove it to cleanup the codes. There would have another two benefits to do so:
1. Reduce the total message size from previous 52 bytes to 20 bytes.
2. Decouple the dependency with `InputChannel#getPartitionId`.
## Brief change log
- *Remove `ResultPartitionID` from `AddCredit` message*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11219:
[FLINK-16257][network] Remove useless ResultPartitionID from AddCredit
message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219#issuecomment-591257565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150597282",
"triggerID" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"triggerType" : "PUSH"
}, {
"hash" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5598",
"triggerID" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75bddc5732f99c88a183b683660a85202ac8c5cb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150597282) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5598)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on a change in pull request #11219:
[FLINK-16257][network] Remove useless ResultPartitionID from AddCredit
message
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on a change in pull request #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219#discussion_r385166074
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
##########
@@ -666,10 +663,7 @@ ByteBuf write(ByteBufAllocator allocator) throws IOException {
ByteBuf result = null;
try {
- result = allocateBuffer(allocator, ID, 16 + 16 + 4 + 16);
-
- partitionId.getPartitionId().writeTo(result);
- partitionId.getProducerId().writeTo(result);
+ result = allocateBuffer(allocator, ID, 4 + 16);
Review comment:
Yes, it seems more readable for this change, but not quite relevant with this PR purpose.
After double checking the codes, there are many other places to take the current way in this class. So I might consider this change as a separate issue for unification future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11219: [FLINK-16257][network]
Remove useless ResultPartitionID from AddCredit message
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219#issuecomment-591252807
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 75bddc5732f99c88a183b683660a85202ac8c5cb (Wed Feb 26 05:51:09 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11219:
[FLINK-16257][network] Remove useless ResultPartitionID from AddCredit
message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219#issuecomment-591257565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150597282",
"triggerID" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75bddc5732f99c88a183b683660a85202ac8c5cb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150597282)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] rkhachatryan commented on a change in pull request #11219:
[FLINK-16257][network] Remove useless ResultPartitionID from AddCredit
message
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on a change in pull request #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219#discussion_r385101114
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
##########
@@ -666,10 +663,7 @@ ByteBuf write(ByteBufAllocator allocator) throws IOException {
ByteBuf result = null;
try {
- result = allocateBuffer(allocator, ID, 16 + 16 + 4 + 16);
-
- partitionId.getPartitionId().writeTo(result);
- partitionId.getProducerId().writeTo(result);
+ result = allocateBuffer(allocator, ID, 4 + 16);
Review comment:
nit: replace numbers with constants `Integer.BYTES` and `Long.BYTES`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW commented on issue #11219: [FLINK-16257][network]
Remove useless ResultPartitionID from AddCredit message
Posted by GitBox <gi...@apache.org>.
zhijiangW commented on issue #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219#issuecomment-592005717
Thanks for the review @rkhachatryan , I replied the inline comments above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11219: [FLINK-16257][network]
Remove useless ResultPartitionID from AddCredit message
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219#issuecomment-591257565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75bddc5732f99c88a183b683660a85202ac8c5cb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11219:
[FLINK-16257][network] Remove useless ResultPartitionID from AddCredit
message
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219#issuecomment-591257565
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"status" : "PENDING",
"url" : "https://travis-ci.com/flink-ci/flink/builds/150597282",
"triggerID" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"triggerType" : "PUSH"
}, {
"hash" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5598",
"triggerID" : "75bddc5732f99c88a183b683660a85202ac8c5cb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75bddc5732f99c88a183b683660a85202ac8c5cb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150597282) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5598)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zhijiangW merged pull request #11219:
[FLINK-16257][network] Remove useless ResultPartitionID from AddCredit
message
Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #11219: [FLINK-16257][network] Remove useless ResultPartitionID from AddCredit message
URL: https://github.com/apache/flink/pull/11219
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services