You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Pierrick HYMBERT <pi...@gmail.com> on 2017/06/22 10:38:35 UTC
PR or Patch File for external contribution ?
Hi,
What is the most appropriate way for log4j team to handle external
contribution ? GitHub Pull Request or Patch file ?
I used to attach patch in jira from my local branch, but then I tried
tutorial from Gary [1] and see that it is possible to ask for PR directly
from github forked repo [2] and then you may merge to apache repo.
Personnaly I feel it more convenient, don't you ?
[1]
https://garygregory.wordpress.com/2016/11/10/how-to-catch-up-my-git-fork-to-master/
[2] https://github.com/phymbert/logging-log4j2
Re: PR or Patch File for external contribution ?
Posted by Mikael Ståldal <mi...@apache.org>.
We would however like to have a JIRA issue even when you open a GitHub
PR, and have them linked together.
On 2017-06-22 21:38, Gary Gregory wrote:
> A JIRA is also a place for discussion but GitHub is much nicer since you
> can comment on actual lines of code. Sweet feature.
>
> Gary
>
> On Thu, Jun 22, 2017 at 12:22 PM, Dominik Psenner <dp...@gmail.com>
> wrote:
>
>> And pull requests provide a place for discussions and code review.
>>
>> 2017-06-22 18:15 GMT+02:00 Matt Sicker <bo...@gmail.com>:
>>
>>> Pull requests are definitely easier to merge, plus you get a nicer online
>>> diff tool that way. Patch files are fine, too, but only if you prefer
>>> submitting them that way.
>>>
>>> On 22 June 2017 at 10:53, Gary Gregory <ga...@gmail.com> wrote:
>>>
>>>> It is really up to you, what ever works for you.
>>>>
>>>> Gary
>>>>
>>>> On Jun 22, 2017 03:38, "Pierrick HYMBERT" <pi...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> What is the most appropriate way for log4j team to handle external
>>>>> contribution ? GitHub Pull Request or Patch file ?
>>>>>
>>>>> I used to attach patch in jira from my local branch, but then I tried
>>>>> tutorial from Gary [1] and see that it is possible to ask for PR
>>> directly
>>>>> from github forked repo [2] and then you may merge to apache repo.
>>>>>
>>>>> Personnaly I feel it more convenient, don't you ?
>>>>>
>>>>> [1]
>>>>> https://garygregory.wordpress.com/2016/11/10/how-to-catch-
>>>>> up-my-git-fork-to-master/
>>>>> [2] https://github.com/phymbert/logging-log4j2
>>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Matt Sicker <bo...@gmail.com>
>>>
>>
>>
>>
>> --
>> Dominik Psenner
>>
>
Re: PR or Patch File for external contribution ?
Posted by Gary Gregory <ga...@gmail.com>.
A JIRA is also a place for discussion but GitHub is much nicer since you
can comment on actual lines of code. Sweet feature.
Gary
On Thu, Jun 22, 2017 at 12:22 PM, Dominik Psenner <dp...@gmail.com>
wrote:
> And pull requests provide a place for discussions and code review.
>
> 2017-06-22 18:15 GMT+02:00 Matt Sicker <bo...@gmail.com>:
>
> > Pull requests are definitely easier to merge, plus you get a nicer online
> > diff tool that way. Patch files are fine, too, but only if you prefer
> > submitting them that way.
> >
> > On 22 June 2017 at 10:53, Gary Gregory <ga...@gmail.com> wrote:
> >
> > > It is really up to you, what ever works for you.
> > >
> > > Gary
> > >
> > > On Jun 22, 2017 03:38, "Pierrick HYMBERT" <pi...@gmail.com>
> > > wrote:
> > >
> > > > Hi,
> > > >
> > > > What is the most appropriate way for log4j team to handle external
> > > > contribution ? GitHub Pull Request or Patch file ?
> > > >
> > > > I used to attach patch in jira from my local branch, but then I tried
> > > > tutorial from Gary [1] and see that it is possible to ask for PR
> > directly
> > > > from github forked repo [2] and then you may merge to apache repo.
> > > >
> > > > Personnaly I feel it more convenient, don't you ?
> > > >
> > > > [1]
> > > > https://garygregory.wordpress.com/2016/11/10/how-to-catch-
> > > > up-my-git-fork-to-master/
> > > > [2] https://github.com/phymbert/logging-log4j2
> > > >
> > >
> >
> >
> >
> > --
> > Matt Sicker <bo...@gmail.com>
> >
>
>
>
> --
> Dominik Psenner
>
Re: PR or Patch File for external contribution ?
Posted by Dominik Psenner <dp...@gmail.com>.
And pull requests provide a place for discussions and code review.
2017-06-22 18:15 GMT+02:00 Matt Sicker <bo...@gmail.com>:
> Pull requests are definitely easier to merge, plus you get a nicer online
> diff tool that way. Patch files are fine, too, but only if you prefer
> submitting them that way.
>
> On 22 June 2017 at 10:53, Gary Gregory <ga...@gmail.com> wrote:
>
> > It is really up to you, what ever works for you.
> >
> > Gary
> >
> > On Jun 22, 2017 03:38, "Pierrick HYMBERT" <pi...@gmail.com>
> > wrote:
> >
> > > Hi,
> > >
> > > What is the most appropriate way for log4j team to handle external
> > > contribution ? GitHub Pull Request or Patch file ?
> > >
> > > I used to attach patch in jira from my local branch, but then I tried
> > > tutorial from Gary [1] and see that it is possible to ask for PR
> directly
> > > from github forked repo [2] and then you may merge to apache repo.
> > >
> > > Personnaly I feel it more convenient, don't you ?
> > >
> > > [1]
> > > https://garygregory.wordpress.com/2016/11/10/how-to-catch-
> > > up-my-git-fork-to-master/
> > > [2] https://github.com/phymbert/logging-log4j2
> > >
> >
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>
--
Dominik Psenner
Re: PR or Patch File for external contribution ?
Posted by Matt Sicker <bo...@gmail.com>.
Pull requests are definitely easier to merge, plus you get a nicer online
diff tool that way. Patch files are fine, too, but only if you prefer
submitting them that way.
On 22 June 2017 at 10:53, Gary Gregory <ga...@gmail.com> wrote:
> It is really up to you, what ever works for you.
>
> Gary
>
> On Jun 22, 2017 03:38, "Pierrick HYMBERT" <pi...@gmail.com>
> wrote:
>
> > Hi,
> >
> > What is the most appropriate way for log4j team to handle external
> > contribution ? GitHub Pull Request or Patch file ?
> >
> > I used to attach patch in jira from my local branch, but then I tried
> > tutorial from Gary [1] and see that it is possible to ask for PR directly
> > from github forked repo [2] and then you may merge to apache repo.
> >
> > Personnaly I feel it more convenient, don't you ?
> >
> > [1]
> > https://garygregory.wordpress.com/2016/11/10/how-to-catch-
> > up-my-git-fork-to-master/
> > [2] https://github.com/phymbert/logging-log4j2
> >
>
--
Matt Sicker <bo...@gmail.com>
Re: PR or Patch File for external contribution ?
Posted by Gary Gregory <ga...@gmail.com>.
It is really up to you, what ever works for you.
Gary
On Jun 22, 2017 03:38, "Pierrick HYMBERT" <pi...@gmail.com>
wrote:
> Hi,
>
> What is the most appropriate way for log4j team to handle external
> contribution ? GitHub Pull Request or Patch file ?
>
> I used to attach patch in jira from my local branch, but then I tried
> tutorial from Gary [1] and see that it is possible to ask for PR directly
> from github forked repo [2] and then you may merge to apache repo.
>
> Personnaly I feel it more convenient, don't you ?
>
> [1]
> https://garygregory.wordpress.com/2016/11/10/how-to-catch-
> up-my-git-fork-to-master/
> [2] https://github.com/phymbert/logging-log4j2
>