You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/06/28 08:22:49 UTC

[GitHub] [incubator-openwhisk-deploy-kube] chetanmeh commented on a change in pull request #482: Add configurations for prometheus and metrics

chetanmeh commented on a change in pull request #482: Add configurations for prometheus and metrics
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/482#discussion_r298498035
 
 

 ##########
 File path: helm/openwhisk/templates/invoker-pod.yaml
 ##########
 @@ -169,7 +169,22 @@ spec:
           # properties for zookeeper connection
           - name: "ZOOKEEPER_HOSTS"
             value: "{{ include "openwhisk.zookeeper_connect" . }}"
-
+{{ if .Values.metrics.prometheusEnabled }}
+          - name: "OPENWHISK_ENCODED_CONFIG"
 
 Review comment:
   @daisy-ycguo encoded config is more for convenience. So you can avoid that for now (and we later do a wholesale move to that for all other configs) and use what @neerajmangal suggested i.e. `Config_whisk_metrics_prometheusEnabled` which should have same effect.
   
   Above PR was more to simplify using the encoded config approach with ansible based setups

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services