You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/09 06:14:31 UTC
[GitHub] [arrow-datafusion] Jimexist opened a new pull request #296: allow datafusion cli to take -- comments
Jimexist opened a new pull request #296:
URL: https://github.com/apache/arrow-datafusion/pull/296
# Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
Closes #.
# Rationale for this change
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
# What changes are included in this PR?
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
# Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please add the `breaking change` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #296: allow datafusion cli to take -- comments
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #296:
URL: https://github.com/apache/arrow-datafusion/pull/296#issuecomment-835710387
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#296](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5e1b074) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/204d4f588a5820f25fc5c6d6599d368c1ee04c3e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (204d4f5) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
- Coverage 75.99% 75.98% -0.01%
==========================================
Files 141 141
Lines 23657 23659 +2
==========================================
Hits 17978 17978
- Misses 5679 5681 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion-cli/src/main.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi1jbGkvc3JjL21haW4ucnM=) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [204d4f5...5e1b074](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #296: allow datafusion cli to take -- comments
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #296:
URL: https://github.com/apache/arrow-datafusion/pull/296#issuecomment-835825711
> > I am wondering, can't we fix the code so comments are parsed correctly rather than skipping them?
> > I believe you might be able to change the code to add new lines rather than a space at the end of every line.
> > ```rust
> > query.push(' ');
> > // To
> > query.push('\n');
> > ```
> >
> >
> > This way we should also parse multiline comments, comments starting with a space, etc correctly.
>
> @Dandandan thanks for the advise. i've updated the appending to use `\n` instead.
>
> However I still think we shall skip `--` starting lines like the changes i made here, otherwise a line with `-- ;` will result in an error
Fair enough, thanks! I think at some point we should remove the `;` check and work together with the parser to detect true statement endings. Untill then this seems a good compromise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #296: allow datafusion cli to take -- comments
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #296:
URL: https://github.com/apache/arrow-datafusion/pull/296#issuecomment-835824636
> I am wondering, can't we fix the code so comments are parsed correctly rather than skipping them?
> I believe you might be able to change the code to add new lines rather than a space at the end of every line.
>
> ```rust
> query.push(' ');
> // To
> query.push('\n');
> ```
>
> This way we should also parse multiline comments, comments starting with a space, etc correctly.
@Dandandan thanks for the advise. i've updated the appending to use `\n` instead.
However I still think we shall skip `--` starting lines like the changes i made here, otherwise a line with `-- ;` will result in an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #296: allow datafusion cli to take -- comments
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #296:
URL: https://github.com/apache/arrow-datafusion/pull/296#issuecomment-835841388
Agreed that this is a compromise - at least writing multiple semicolons will still break A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #296: allow datafusion cli to take -- comments
Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #296:
URL: https://github.com/apache/arrow-datafusion/pull/296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Jimexist commented on pull request #296: allow datafusion cli to take -- comments
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #296:
URL: https://github.com/apache/arrow-datafusion/pull/296#issuecomment-835705683
```
❯ cargo run --release --bin datafusion-cli -q
> -- hello
> select 1 num;
+-----+
| num |
+-----+
| 1 |
+-----+
1 rows in set. Query took 0 seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #296: allow datafusion cli to take -- comments
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #296:
URL: https://github.com/apache/arrow-datafusion/pull/296#issuecomment-835710387
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#296](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2dd4c5d) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/d0a4552dcf07316acaa8ade7feabe5c9165f3a48?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0a4552) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
- Coverage 76.07% 76.06% -0.01%
==========================================
Files 140 140
Lines 23632 23634 +2
==========================================
Hits 17978 17978
- Misses 5654 5656 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion-cli/src/main.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/296/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi1jbGkvc3JjL21haW4ucnM=) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d0a4552...2dd4c5d](https://codecov.io/gh/apache/arrow-datafusion/pull/296?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org