You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/20 11:56:57 UTC
[GitHub] [flink] klion26 commented on a change in pull request #10178:
[FLINK-14433][DataStream] Move generated Jaas conf file from /tmp directory
to Job specific directory
klion26 commented on a change in pull request #10178: [FLINK-14433][DataStream] Move generated Jaas conf file from /tmp directory to Job specific directory
URL: https://github.com/apache/flink/pull/10178#discussion_r348440924
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/modules/JaasModule.java
##########
@@ -140,10 +155,12 @@ public DynamicConfiguration getCurrentConfiguration() {
/**
* Generate the default JAAS config file.
*/
- private static File generateDefaultConfigFile() {
+ private static File generateDefaultConfigFile(String workingDir) {
+ checkArgument(workingDir != null, "working directory should not be null.");
final File jaasConfFile;
try {
- Path jaasConfPath = Files.createTempFile("jaas-", ".conf");
+ Path path = Paths.get(workingDir);
+ Path jaasConfPath = Files.createTempFile(path, "jaas-", ".conf");
Review comment:
It names with "jaas-" when introduced this module, so I reuse "jaas-" not "jaas" in current pr.
I think the author wanted to add a "-" between "jaas" and the UUID.
I attached a picture from our production env
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services