You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@logging.apache.org by kpm1985 <gi...@git.apache.org> on 2017/07/28 17:32:47 UTC

[GitHub] logging-log4j2 pull request #101: LOG4J2-Fix type warnings and remove deprec...

GitHub user kpm1985 opened a pull request:

    https://github.com/apache/logging-log4j2/pull/101

    LOG4J2-Fix type warnings and remove deprecated methods where appropriate

    Unit tests pass. Maven builds successfully.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kpm1985/logging-log4j2 dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/101.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #101
    
----
commit 65b75bfe60c4e670cc5369dffc40ad3d844db983
Author: Kenneth McFarland <ke...@gmail.com>
Date:   2017-07-28T15:21:30Z

    Fix type warnings and remove deprecated methods where appropriate

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] logging-log4j2 issue #101: LOG4J2-Fix type warnings and remove deprecated me...

Posted by kenneth mcfarland <ke...@gmail.com>.

Thank you for the corrections, stupid mistakes and you just schooled me
about type inference 🤕

On Jul 28, 2017 12:03 PM, "garydgregory" <gi...@git.apache.org> wrote:

> Github user garydgregory commented on the issue:
>
>     https://github.com/apache/logging-log4j2/pull/101
>
>     Thank you for the patch.
>
>     In the future, please do not use redundant type arguments.
>
>     For example:
>
>     HashSet<String> foo = new HashSet<String>();
>
>     can simply be:
>
>     HashSet<String> foo = new HashSet<>()
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] logging-log4j2 issue #101: LOG4J2-Fix type warnings and remove deprecated me...

Posted by garydgregory <gi...@git.apache.org>.

Github user garydgregory commented on the issue:

    https://github.com/apache/logging-log4j2/pull/101
  
    Thank you for the patch.
    
    In the future, please do not use redundant type arguments. 
    
    For example:
    
    HashSet<String> foo = new HashSet<String>();
    
    can simply be:
    
    HashSet<String> foo = new HashSet<>()



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] logging-log4j2 pull request #101: LOG4J2-Fix type warnings and remove deprec...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/logging-log4j2/pull/101


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---