You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/03/13 14:12:54 UTC

Review Request 32043: LENS-408: Fix usage of new HiveConf()

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32043/
-----------------------------------------------------------

Review request for lens, Jaideep dhok and Rajat Khandelwal.


Bugs: LENS-408
    https://issues.apache.org/jira/browse/LENS-408


Repository: lens


Description
-------

With the changes put up new HiveConf() is created atmost once for query


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java cd40a75 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 871ce65 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 96e6f34 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 3e66157 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 4cf9bbd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 81d91eb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ecf0f3b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 5e9bc2d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 44c474a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 9cea231 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java b905f70 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3fbdee9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0669074 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java cf8c57b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java f7bd3b8 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java a1451b9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 84c4c44 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8f7da7d 
  lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 6e758a6 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 4de5bd7 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e7619ed 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java de4645c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java 8bf92f2 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 28dd662 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 6f9dd5b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java f62170f 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f3be3fb 
  lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java 0d441c8 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java 0a0cfbd 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 9dce099 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 49d01d2 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java ac34760 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java 3b38813 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java 078988b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f9f6645 

Diff: https://reviews.apache.org/r/32043/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.274s]
[INFO] Lens .............................................. SUCCESS [1.732s]
[INFO] Lens API .......................................... SUCCESS [6.041s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.460s]
[INFO] Lens Cube ......................................... SUCCESS [2:03.646s]
[INFO] Lens DB storage ................................... SUCCESS [10.513s]
[INFO] Lens Query Library ................................ SUCCESS [4.701s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.986s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [19.141s]
[INFO] Lens Server ....................................... SUCCESS [4:14.307s]
[INFO] Lens client ....................................... SUCCESS [21.676s]
[INFO] Lens CLI .......................................... SUCCESS [1:50.739s]
[INFO] Lens Examples ..................................... SUCCESS [0.997s]
[INFO] Lens Distribution ................................. SUCCESS [9.438s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.282s]
[INFO] Lens Regression ................................... SUCCESS [0.462s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:50.333s
[INFO] Finished at: Fri Mar 13 13:03:31 UTC 2015
[INFO] Final Memory: 109M/941M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 32043: LENS-408: Fix usage of new HiveConf()

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32043/#review76523
-----------------------------------------------------------

Ship it!



lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
<https://reviews.apache.org/r/32043/#comment124101>

    Does this have to be synchronized?


- Jaideep dhok


On March 16, 2015, 5:29 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32043/
> -----------------------------------------------------------
> 
> (Updated March 16, 2015, 5:29 a.m.)
> 
> 
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
> 
> 
> Bugs: LENS-408
>     https://issues.apache.org/jira/browse/LENS-408
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> With the changes put up new HiveConf() is created atmost once for query
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java cd40a75 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 871ce65 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 96e6f34 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 3e66157 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 4cf9bbd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 81d91eb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ecf0f3b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 5e9bc2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 44c474a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 9cea231 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java b905f70 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3fbdee9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0669074 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java cf8c57b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java f7bd3b8 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java a1451b9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 84c4c44 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8f7da7d 
>   lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 6e758a6 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 4de5bd7 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e7619ed 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java de4645c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java 8bf92f2 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 28dd662 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 6f9dd5b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java f62170f 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f3be3fb 
>   lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java 0d441c8 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java 0a0cfbd 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 9dce099 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 49d01d2 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java ac34760 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java 3b38813 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java 078988b 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f9f6645 
> 
> Diff: https://reviews.apache.org/r/32043/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.114s]
> [INFO] Lens .............................................. SUCCESS [1.778s]
> [INFO] Lens API .......................................... SUCCESS [5.463s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.500s]
> [INFO] Lens Cube ......................................... SUCCESS [2:03.905s]
> [INFO] Lens DB storage ................................... SUCCESS [10.720s]
> [INFO] Lens Query Library ................................ SUCCESS [4.693s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:35.359s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [17.636s]
> [INFO] Lens Server ....................................... SUCCESS [4:13.146s]
> [INFO] Lens client ....................................... SUCCESS [21.253s]
> [INFO] Lens CLI .......................................... SUCCESS [1:44.068s]
> [INFO] Lens Examples ..................................... SUCCESS [0.923s]
> [INFO] Lens Distribution ................................. SUCCESS [9.423s]
> [INFO] Lens ML Lib ....................................... SUCCESS [42.266s]
> [INFO] Lens Regression ................................... SUCCESS [0.457s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:40.650s
> [INFO] Finished at: Mon Mar 16 05:25:51 UTC 2015
> [INFO] Final Memory: 113M/1335M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 32043: LENS-408: Fix usage of new HiveConf()

Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32043/#review76532
-----------------------------------------------------------

Ship it!


Ship It!

- Jaideep dhok


On March 16, 2015, 7:12 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32043/
> -----------------------------------------------------------
> 
> (Updated March 16, 2015, 7:12 a.m.)
> 
> 
> Review request for lens, Jaideep dhok and Rajat Khandelwal.
> 
> 
> Bugs: LENS-408
>     https://issues.apache.org/jira/browse/LENS-408
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> With the changes put up new HiveConf() is created atmost once for query
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java cd40a75 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 871ce65 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 96e6f34 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 3e66157 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 4cf9bbd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 81d91eb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ecf0f3b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 5e9bc2d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 44c474a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 9cea231 
>   lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java b905f70 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3fbdee9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0669074 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java cf8c57b 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java f7bd3b8 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java a1451b9 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 84c4c44 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8f7da7d 
>   lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 6e758a6 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 4de5bd7 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e7619ed 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java de4645c 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java 8bf92f2 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java df01ba7 
>   lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 1d68eb5 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 0bcbe7b 
>   lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 912e201 
>   lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java 0d441c8 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 0f68cb9 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 088076e 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java 0a0cfbd 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 9dce099 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 49d01d2 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java ac34760 
>   lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java 3b38813 
>   lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java 078988b 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f9f6645 
> 
> Diff: https://reviews.apache.org/r/32043/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.390s]
> [INFO] Lens .............................................. SUCCESS [1.976s]
> [INFO] Lens API .......................................... SUCCESS [6.962s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.244s]
> [INFO] Lens Cube ......................................... SUCCESS [2:04.600s]
> [INFO] Lens DB storage ................................... SUCCESS [10.453s]
> [INFO] Lens Query Library ................................ SUCCESS [4.547s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.801s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [16.884s]
> [INFO] Lens Server ....................................... SUCCESS [4:24.699s]
> [INFO] Lens client ....................................... SUCCESS [21.881s]
> [INFO] Lens CLI .......................................... SUCCESS [1:40.493s]
> [INFO] Lens Examples ..................................... SUCCESS [0.781s]
> [INFO] Lens Distribution ................................. SUCCESS [9.253s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.717s]
> [INFO] Lens Regression ................................... SUCCESS [0.472s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 12:54.081s
> [INFO] Finished at: Mon Mar 16 07:10:28 UTC 2015
> [INFO] Final Memory: 109M/970M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 32043: LENS-408: Fix usage of new HiveConf()

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32043/
-----------------------------------------------------------

(Updated March 16, 2015, 7:12 a.m.)


Review request for lens, Jaideep dhok and Rajat Khandelwal.


Changes
-------

Updated to master


Bugs: LENS-408
    https://issues.apache.org/jira/browse/LENS-408


Repository: lens


Description
-------

With the changes put up new HiveConf() is created atmost once for query


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java cd40a75 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 871ce65 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 96e6f34 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 3e66157 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 4cf9bbd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 81d91eb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ecf0f3b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 5e9bc2d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 44c474a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 9cea231 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java b905f70 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3fbdee9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0669074 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java cf8c57b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java f7bd3b8 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java a1451b9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 84c4c44 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8f7da7d 
  lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 6e758a6 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 4de5bd7 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e7619ed 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java de4645c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java 8bf92f2 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java df01ba7 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 1d68eb5 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 0bcbe7b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 912e201 
  lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java 0d441c8 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 0f68cb9 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 088076e 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java 0a0cfbd 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 9dce099 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 49d01d2 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java ac34760 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java 3b38813 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java 078988b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f9f6645 

Diff: https://reviews.apache.org/r/32043/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.390s]
[INFO] Lens .............................................. SUCCESS [1.976s]
[INFO] Lens API .......................................... SUCCESS [6.962s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.244s]
[INFO] Lens Cube ......................................... SUCCESS [2:04.600s]
[INFO] Lens DB storage ................................... SUCCESS [10.453s]
[INFO] Lens Query Library ................................ SUCCESS [4.547s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.801s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [16.884s]
[INFO] Lens Server ....................................... SUCCESS [4:24.699s]
[INFO] Lens client ....................................... SUCCESS [21.881s]
[INFO] Lens CLI .......................................... SUCCESS [1:40.493s]
[INFO] Lens Examples ..................................... SUCCESS [0.781s]
[INFO] Lens Distribution ................................. SUCCESS [9.253s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.717s]
[INFO] Lens Regression ................................... SUCCESS [0.472s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:54.081s
[INFO] Finished at: Mon Mar 16 07:10:28 UTC 2015
[INFO] Final Memory: 109M/970M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 32043: LENS-408: Fix usage of new HiveConf()

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32043/
-----------------------------------------------------------

(Updated March 16, 2015, 5:29 a.m.)


Review request for lens, Jaideep dhok and Rajat Khandelwal.


Bugs: LENS-408
    https://issues.apache.org/jira/browse/LENS-408


Repository: lens


Description
-------

With the changes put up new HiveConf() is created atmost once for query


Diffs
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java cd40a75 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 871ce65 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 96e6f34 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 3e66157 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 4cf9bbd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 81d91eb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ecf0f3b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 5e9bc2d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 44c474a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 9cea231 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java b905f70 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3fbdee9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0669074 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java cf8c57b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java f7bd3b8 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java a1451b9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 84c4c44 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8f7da7d 
  lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 6e758a6 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 4de5bd7 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e7619ed 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java de4645c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java 8bf92f2 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 28dd662 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 6f9dd5b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java f62170f 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f3be3fb 
  lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java 0d441c8 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java 0a0cfbd 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 9dce099 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 49d01d2 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java ac34760 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java 3b38813 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java 078988b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f9f6645 

Diff: https://reviews.apache.org/r/32043/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.114s]
[INFO] Lens .............................................. SUCCESS [1.778s]
[INFO] Lens API .......................................... SUCCESS [5.463s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.500s]
[INFO] Lens Cube ......................................... SUCCESS [2:03.905s]
[INFO] Lens DB storage ................................... SUCCESS [10.720s]
[INFO] Lens Query Library ................................ SUCCESS [4.693s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:35.359s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [17.636s]
[INFO] Lens Server ....................................... SUCCESS [4:13.146s]
[INFO] Lens client ....................................... SUCCESS [21.253s]
[INFO] Lens CLI .......................................... SUCCESS [1:44.068s]
[INFO] Lens Examples ..................................... SUCCESS [0.923s]
[INFO] Lens Distribution ................................. SUCCESS [9.423s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.266s]
[INFO] Lens Regression ................................... SUCCESS [0.457s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:40.650s
[INFO] Finished at: Mon Mar 16 05:25:51 UTC 2015
[INFO] Final Memory: 113M/1335M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 32043: LENS-408: Fix usage of new HiveConf()

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32043/
-----------------------------------------------------------

(Updated March 16, 2015, 5:14 a.m.)


Review request for lens, Jaideep dhok and Rajat Khandelwal.


Bugs: LENS-408
    https://issues.apache.org/jira/browse/LENS-408


Repository: lens


Description
-------

With the changes put up new HiveConf() is created atmost once for query


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java cd40a75 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 871ce65 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 96e6f34 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 3e66157 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 4cf9bbd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 81d91eb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ecf0f3b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 5e9bc2d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 44c474a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 9cea231 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java b905f70 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3fbdee9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0669074 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java cf8c57b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java f7bd3b8 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java a1451b9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 84c4c44 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8f7da7d 
  lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 6e758a6 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 4de5bd7 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e7619ed 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java de4645c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java 8bf92f2 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 28dd662 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 6f9dd5b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java f62170f 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f3be3fb 
  lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java 0d441c8 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java 0a0cfbd 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 9dce099 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 49d01d2 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java ac34760 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java 3b38813 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java 078988b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f9f6645 

Diff: https://reviews.apache.org/r/32043/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.274s]
[INFO] Lens .............................................. SUCCESS [1.732s]
[INFO] Lens API .......................................... SUCCESS [6.041s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.460s]
[INFO] Lens Cube ......................................... SUCCESS [2:03.646s]
[INFO] Lens DB storage ................................... SUCCESS [10.513s]
[INFO] Lens Query Library ................................ SUCCESS [4.701s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.986s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [19.141s]
[INFO] Lens Server ....................................... SUCCESS [4:14.307s]
[INFO] Lens client ....................................... SUCCESS [21.676s]
[INFO] Lens CLI .......................................... SUCCESS [1:50.739s]
[INFO] Lens Examples ..................................... SUCCESS [0.997s]
[INFO] Lens Distribution ................................. SUCCESS [9.438s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.282s]
[INFO] Lens Regression ................................... SUCCESS [0.462s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:50.333s
[INFO] Finished at: Fri Mar 13 13:03:31 UTC 2015
[INFO] Final Memory: 109M/941M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 32043: LENS-408: Fix usage of new HiveConf()

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32043/
-----------------------------------------------------------

(Updated March 13, 2015, 1:46 p.m.)


Review request for lens, Jaideep dhok and Rajat Khandelwal.


Bugs: LENS-408
    https://issues.apache.org/jira/browse/LENS-408


Repository: lens


Description
-------

With the changes put up new HiveConf() is created atmost once for query


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java cd40a75 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 871ce65 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 96e6f34 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 3e66157 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 4cf9bbd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 81d91eb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java ecf0f3b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 5e9bc2d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 44c474a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 9cea231 
  lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java b905f70 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 3fbdee9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 0669074 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java cf8c57b 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java f7bd3b8 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java a1451b9 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java 84c4c44 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 8f7da7d 
  lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java 6e758a6 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 4de5bd7 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java e7619ed 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java de4645c 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/ThriftConnection.java 8bf92f2 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java 28dd662 
  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 6f9dd5b 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java f62170f 
  lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java f3be3fb 
  lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java 0d441c8 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 432c863 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 94b5daf 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java 0a0cfbd 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java 9dce099 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 49d01d2 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java ac34760 
  lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java 3b38813 
  lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java 078988b 
  lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f9f6645 

Diff: https://reviews.apache.org/r/32043/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.274s]
[INFO] Lens .............................................. SUCCESS [1.732s]
[INFO] Lens API .......................................... SUCCESS [6.041s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.460s]
[INFO] Lens Cube ......................................... SUCCESS [2:03.646s]
[INFO] Lens DB storage ................................... SUCCESS [10.513s]
[INFO] Lens Query Library ................................ SUCCESS [4.701s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.986s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [19.141s]
[INFO] Lens Server ....................................... SUCCESS [4:14.307s]
[INFO] Lens client ....................................... SUCCESS [21.676s]
[INFO] Lens CLI .......................................... SUCCESS [1:50.739s]
[INFO] Lens Examples ..................................... SUCCESS [0.997s]
[INFO] Lens Distribution ................................. SUCCESS [9.438s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.282s]
[INFO] Lens Regression ................................... SUCCESS [0.462s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:50.333s
[INFO] Finished at: Fri Mar 13 13:03:31 UTC 2015
[INFO] Final Memory: 109M/941M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu