You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/02/06 00:34:47 UTC
[GitHub] [tvm] tkonolige opened a new pull request #7417: [FIX,CMAKE] Only compile runtime files once
tkonolige opened a new pull request #7417:
URL: https://github.com/apache/tvm/pull/7417
@jroesch @tqchen @areusch @junrushao1994
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #7417: [FIX,CMAKE] Only compile runtime files once
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #7417:
URL: https://github.com/apache/tvm/pull/7417
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a change in pull request #7417: [FIX,CMAKE] Only compile runtime files once
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7417:
URL: https://github.com/apache/tvm/pull/7417#discussion_r571328231
##########
File path: CMakeLists.txt
##########
@@ -371,10 +371,10 @@ endif()
add_lib_info(${CMAKE_CURRENT_LIST_DIR}/src/support/libinfo.cc)
-add_library(tvm_objs OBJECT ${COMPILER_SRCS} ${RUNTIME_SRCS})
Review comment:
These defines were already broken/inconsistent, but I've fixed them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jroesch commented on pull request #7417: [FIX,CMAKE] Only compile runtime files once
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #7417:
URL: https://github.com/apache/tvm/pull/7417#issuecomment-775539157
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tkonolige commented on a change in pull request #7417: [FIX,CMAKE] Only compile runtime files once
Posted by GitBox <gi...@apache.org>.
tkonolige commented on a change in pull request #7417:
URL: https://github.com/apache/tvm/pull/7417#discussion_r571329085
##########
File path: CMakeLists.txt
##########
@@ -371,10 +371,10 @@ endif()
add_lib_info(${CMAKE_CURRENT_LIST_DIR}/src/support/libinfo.cc)
-add_library(tvm_objs OBJECT ${COMPILER_SRCS} ${RUNTIME_SRCS})
+add_library(tvm_objs OBJECT ${COMPILER_SRCS})
add_library(tvm_runtime_objs OBJECT ${RUNTIME_SRCS})
-add_library(tvm SHARED $<TARGET_OBJECTS:tvm_objs>)
+add_library(tvm SHARED $<TARGET_OBJECTS:tvm_objs> $<TARGET_OBJECTS:tvm_runtime_objs>)
Review comment:
got that one in the second commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #7417: [FIX,CMAKE] Only compile runtime files once
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #7417:
URL: https://github.com/apache/tvm/pull/7417#discussion_r571328859
##########
File path: CMakeLists.txt
##########
@@ -371,10 +371,10 @@ endif()
add_lib_info(${CMAKE_CURRENT_LIST_DIR}/src/support/libinfo.cc)
-add_library(tvm_objs OBJECT ${COMPILER_SRCS} ${RUNTIME_SRCS})
+add_library(tvm_objs OBJECT ${COMPILER_SRCS})
add_library(tvm_runtime_objs OBJECT ${RUNTIME_SRCS})
-add_library(tvm SHARED $<TARGET_OBJECTS:tvm_objs>)
+add_library(tvm SHARED $<TARGET_OBJECTS:tvm_objs> $<TARGET_OBJECTS:tvm_runtime_objs>)
Review comment:
I think you also need to change line 450
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #7417: [FIX,CMAKE] Only compile runtime files once
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7417:
URL: https://github.com/apache/tvm/pull/7417#discussion_r571326553
##########
File path: CMakeLists.txt
##########
@@ -371,10 +371,10 @@ endif()
add_lib_info(${CMAKE_CURRENT_LIST_DIR}/src/support/libinfo.cc)
-add_library(tvm_objs OBJECT ${COMPILER_SRCS} ${RUNTIME_SRCS})
Review comment:
decoupling runtime source from`tvm_objs` might require cross check other locations that refers to it.
e.g. https://github.com/apache/tvm/blob/main/CMakeLists.txt#L396
So that the runtime source and compiler part build with the same flag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org