You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2008/07/15 17:31:31 UTC
[jira] Created: (HADOOP-3761) FileSplit's default constructor
should be made "public"
FileSplit's default constructor should be made "public"
-------------------------------------------------------
Key: HADOOP-3761
URL: https://issues.apache.org/jira/browse/HADOOP-3761
Project: Hadoop Core
Issue Type: Improvement
Components: mapred
Reporter: Zheng Shao
Assignee: Zheng Shao
Priority: Trivial
mapred.FileSplit's default constructor is currently "package" visible. We should make it "public" so we can support a GenericSplit class outside mapred package, which could create FileSplit instances using reflection and serialize/deserialize FileSplit through Writable interface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3761) FileSplit's default constructor
should be made "public"
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613644#action_12613644 ]
Owen O'Malley commented on HADOOP-3761:
---------------------------------------
Making the constructor visible is reasonable, but it isn't necessary if you use ReflectionUtils.newInstance to make instance. Even better is using the serialization framework so that it supports arbitrary types (Thrift, Writable, ProtocolBuffers, etc)
> FileSplit's default constructor should be made "public"
> -------------------------------------------------------
>
> Key: HADOOP-3761
> URL: https://issues.apache.org/jira/browse/HADOOP-3761
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Trivial
> Attachments: 3761-1.patch
>
>
> mapred.FileSplit's default constructor is currently "package" visible. We should make it "public" so we can support a GenericSplit class outside mapred package, which could create FileSplit instances using reflection and serialize/deserialize FileSplit through Writable interface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3761) FileSplit's default constructor
should be made "public"
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HADOOP-3761:
-------------------------------
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
> FileSplit's default constructor should be made "public"
> -------------------------------------------------------
>
> Key: HADOOP-3761
> URL: https://issues.apache.org/jira/browse/HADOOP-3761
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Trivial
> Attachments: 3761-1.patch
>
>
> mapred.FileSplit's default constructor is currently "package" visible. We should make it "public" so we can support a GenericSplit class outside mapred package, which could create FileSplit instances using reflection and serialize/deserialize FileSplit through Writable interface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3761) FileSplit's default constructor
should be made "public"
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613689#action_12613689 ]
Zheng Shao commented on HADOOP-3761:
------------------------------------
That makes sense.
> FileSplit's default constructor should be made "public"
> -------------------------------------------------------
>
> Key: HADOOP-3761
> URL: https://issues.apache.org/jira/browse/HADOOP-3761
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Trivial
> Attachments: 3761-1.patch
>
>
> mapred.FileSplit's default constructor is currently "package" visible. We should make it "public" so we can support a GenericSplit class outside mapred package, which could create FileSplit instances using reflection and serialize/deserialize FileSplit through Writable interface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3761) FileSplit's default constructor
should be made "public"
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HADOOP-3761:
-------------------------------
Attachment: 3761-1.patch
> FileSplit's default constructor should be made "public"
> -------------------------------------------------------
>
> Key: HADOOP-3761
> URL: https://issues.apache.org/jira/browse/HADOOP-3761
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Trivial
> Attachments: 3761-1.patch
>
>
> mapred.FileSplit's default constructor is currently "package" visible. We should make it "public" so we can support a GenericSplit class outside mapred package, which could create FileSplit instances using reflection and serialize/deserialize FileSplit through Writable interface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3761) FileSplit's default constructor
should be made "public"
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HADOOP-3761:
-------------------------------
Status: Patch Available (was: Open)
> FileSplit's default constructor should be made "public"
> -------------------------------------------------------
>
> Key: HADOOP-3761
> URL: https://issues.apache.org/jira/browse/HADOOP-3761
> Project: Hadoop Core
> Issue Type: Improvement
> Components: mapred
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Priority: Trivial
> Attachments: 3761-1.patch
>
>
> mapred.FileSplit's default constructor is currently "package" visible. We should make it "public" so we can support a GenericSplit class outside mapred package, which could create FileSplit instances using reflection and serialize/deserialize FileSplit through Writable interface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.