You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by bmehner <gi...@git.apache.org> on 2016/05/20 14:07:01 UTC
[GitHub] metamodel pull request: Fix for encoding error when using InputStr...
GitHub user bmehner opened a pull request:
https://github.com/apache/metamodel/pull/104
Fix for encoding error when using InputStreams
Fixes https://issues.apache.org/jira/browse/METAMODEL-1086
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bmehner/metamodel master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
----
commit 6219cfa6e6ac4bc4e9ce5ab5ceca7abcd3d3b778
Author: Bj�rn Mehner <bj...@3c-d.de>
Date: 2016-05-20T14:04:12Z
Fix for encoding error when using InputStreams
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #104: Fix for encoding error when using InputStreams
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Fix for encoding error when using InputStr...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/104#discussion_r64326605
--- Diff: csv/src/main/java/org/apache/metamodel/csv/CsvDataContext.java ---
@@ -244,7 +227,7 @@ private static File createFileFromInputStream(InputStream inputStream, String en
file = fileCandidate;
final BufferedWriter writer = FileHelper.getBufferedWriter(file, encoding);
- final BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream));
+ final BufferedReader reader = new BufferedReader(new InputStreamReader(inputStream, Charset.forName(encoding)));
--- End diff --
For the sake of consistency, would it be nicer to use `FileHelper.getBufferedReader(inputStream, encoding)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Fix for encoding error when using InputStr...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/104#issuecomment-220652323
Travis error seems unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #104: Fix for encoding error when using InputStreams
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/104
Sorry for the long wait - I didn't realize that you had changed the branch since my remark.
+1 and let's merge! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---