You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2020/06/12 03:52:29 UTC

[GitHub] [incubator-datasketches-java] leerho commented on a change in pull request #321: Improvements in Theta Sketch to (hopefully) eliminate the

leerho commented on a change in pull request #321:
URL: https://github.com/apache/incubator-datasketches-java/pull/321#discussion_r439192668



##########
File path: src/test/java/org/apache/datasketches/theta/EmptyTest.java
##########
@@ -111,45 +105,6 @@ public void checkPsampling() {
     assertEquals(sk1.compact().toByteArray().length, 8);
   }
 
-  //These 3 tests reproduce a failure mode where an "old" empty sketch of 8 bytes without

Review comment:
       This was an accident.  Replaced them.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org