You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Alex Harui <ah...@adobe.com.INVALID> on 2020/01/28 19:54:49 UTC
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Ran into this while doing the has/is refactor.
In what ways is this different than the labelField in IDataProviderModel?
Thanks,
-Alex
On 6/29/17, 12:22 PM, "piotrz@apache.org" <pi...@apache.org> wrote:
FLEX-35328 - Update MDLExample with DataFieldProviderBead
Project: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=BE4Z7ZcUMq%2FhFpeKmsQUAeqzgHHQ4fBT5JKJGOAQXLQ%3D&reserved=0
Commit: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=18wyjAOAvTeMBC41hZK32BZ5yEBwL0q3eY6aOedltVo%3D&reserved=0
Tree: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=oizDT4asGP%2F3V4FKy2otyMW5PqmufwThJblkaC2YmKk%3D&reserved=0
Diff: https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=gadfSlqR%2BTh%2F5pirsxkEvSjF9PnrZO2mlIlhlWiNrpY%3D&reserved=0
Branch: refs/heads/develop
Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
Parents: eaa33ea
Author: piotrz <pi...@apache.org>
Authored: Sun Jun 25 19:27:09 2017 +0200
Committer: piotrz <pi...@apache.org>
Committed: Sun Jun 25 19:27:09 2017 +0200
----------------------------------------------------------------------
examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=QBzrdEaKyzEBxXfodisqDQFthzf0%2FXwKB6GE22q9c2Y%3D&reserved=0
----------------------------------------------------------------------
diff --git a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
index 14d14fd..4231328 100644
--- a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
+++ b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
@@ -38,7 +38,7 @@ limitations under the License.
sourceID="menuModel"
sourcePropertyName="menuItems"
destinationPropertyName="dataProvider" />
- <models2:DataFieldProviderModel dataField="value"/>
+ <js:DataFieldProviderBead dataField="value"/>
</mdl:beads>
</mdl:DropDownList>
</mdl:GridCell>
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Carlos Rovira <ca...@apache.org>.
Hi Alex,
I can confirm that Jewel DataChooser does not need that method. For that
reason, I told you that I see it like "just-in-case", not PAYG. Don't think
it should be needed.
In the other hand, DateChooser in Jewel, implemented many things missing in
Basic and fixed many bugs. Instead of recreaiting in Basic from scratch you
can refactor best practices from Jewel to Basic, so main functionality
reside in Basic and Jewel uses it. I can invest time in testing Jewel does
not break for things like this. I expect this will happen with many other
components, so don't think the solution is to create new methods, since
that way will cause to have many "just-in-case" code in Jewel over time,
and in that case I'll prefer to move from Basic, since it can be utopian
share common code if each one rolls to one side without worrying about the
other
El vie., 31 ene. 2020 a las 20:21, Alex Harui (<ah...@adobe.com.invalid>)
escribió:
> I couldn't easily tell if those differences are new features or fixed
> bugs. Bug fixes that all users of DateChooserModel will need should go in
> the Basic one. Similarly, the change I made to Jewel's DateChooserModel
> to fix the build was a quick one. I only added the missing property but
> didn't hook it up to anything as I don't know if there is Jewel has the
> same problem or not or can be refactored to leverage more code and the fix
> from the Basic one.
>
> -Alex
>
> On 1/31/20, 11:04 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>
> About Jewel DateChooserModel, if you compare with Basic one will see
> that
> has several more code, since implements a lot of things that was
> missed in
> the Basic one.
>
> El vie., 31 ene. 2020 a las 19:58, Carlos Rovira (<
> carlosrovira@apache.org>)
> escribió:
>
> > Hi Alex,
> >
> > the problem is in dataProviderChangeHandler method
> > Basic is adding styles just in case like this:
> >
> > var style:SimpleCSSStyles = new SimpleCSSStyles();
> > style.marginBottom = presentationModel.separatorThickness;
> > UIBase(ir).style = style;
> >
> > while Jewel tries to minimize (or remove at all) any set of styles
> and
> > uses CSS
> >
> > As well
> >
> > UIBase(ir).percentWidth = 100;
> >
> > is removed too.
> >
> > another thing is
> >
> > dataGroup.addItemRenderer(ir, false);
> >
> > is executed at in other order in other place, I think I need to do
> that
> > for some reason, but don't remember why
> >
> > For that reason, I was proposing to refactor to extend the basic one.
> >
> > What do you think?
> >
> > El vie., 31 ene. 2020 a las 18:09, Alex Harui
> (<ah...@adobe.com.invalid>)
> > escribió:
> >
> >> Hi Carlos,
> >>
> >> The diff I ran didn't show anything obvious. And as you noted in
> >> another email, there is a copy of DateChooserModel in Jewel I
> didn't see
> >> that I will fix shortly.
> >>
> >> Are we still concerned about re-use of Basic beads? I thought all
> visual
> >> CSS from Basic was moved to a Theme. It may also be that we need
> to get
> >> better at using interfaces (and the "has" pattern) and maybe more
> of these
> >> beads and models can go in Core or maybe some other SWC.
> >>
> >> -Alex
> >>
> >> On 1/31/20, 4:01 AM, "Carlos Rovira" <ca...@apache.org>
> wrote:
> >>
> >> Hi Alex,
> >> I've missed this email, sorry. I was comparing code and there's
> >> various
> >> changes most of all at the end of the file that are important
> for
> >> Jewel,
> >> I can try to make it extend the Basic Bead and see if that's
> possible
> >> and
> >> saves something
> >>
> >> El mié., 29 ene. 2020 a las 20:48, Alex Harui
> >> (<ah...@adobe.com.invalid>)
> >> escribió:
> >>
> >> > @Carlos,
> >> >
> >> > While we're on the subject, it appears that Jewel has an
> actual
> >> copy of,
> >> > for example, Basic's DataItemRendererFactoryForArrayData.
> What is
> >> the
> >> > rationale for that? Is there some subtle difference I'm not
> seeing
> >> or can
> >> > we get rid of the duplicate copy?
> >> >
> >> > -Alex
> >> >
> >> > On 1/29/20, 8:46 AM, "Carlos Rovira" <carlosrovira@apache.org
> >
> >> wrote:
> >> >
> >> > It's ok to change it if other changes done this past
> months
> >> make MDL
> >> > DDL
> >> > continue to work
> >> > Maybe others are using it since is a full working set and
> we
> >> should
> >> > ensure
> >> > it continue to work
> >> > thanks
> >> >
> >> > El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
> >> > piotrzarzycki21@gmail.com>) escribió:
> >> >
> >> > > Hi Alex,
> >> > >
> >> > > I remember that DropDownl list was lack of dataField
> actually.
> >> > Instead of
> >> > > adding it trough property - I have created Bead which
> >> provides that
> >> > > feature. Whether it's needed now or not is actually
> something
> >> I have
> >> > no
> >> > > idea about. I'm ok with removing it.
> >> > >
> >> > >
> >> > > wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com>
> >> napisał(a):
> >> > >
> >> > > > Ran into this while doing the has/is refactor.
> >> > > >
> >> > > > In what ways is this different than the labelField in
> >> > IDataProviderModel?
> >> > > >
> >> > > > Thanks,
> >> > > > -Alex
> >> > > >
> >> > > > On 6/29/17, 12:22 PM, "piotrz@apache.org" <
> >> piotrz@apache.org>
> >> > wrote:
> >> > > >
> >> > > > FLEX-35328 - Update MDLExample with
> >> DataFieldProviderBead
> >> > > >
> >> > > >
> >> > > > Project:
> >> > > >
> >> > >
> >> >
> >>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=q8gSix2CL6OlUeEMc0S%2FFiYMnL9aleIjEXxXCoG3r94%3D&reserved=0
> >> > > > Commit:
> >> > > >
> >> > >
> >> >
> >>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=7eBQKt2xSkYsAkEB6%2BxjOwTG4gagT2NhDR4FkQUvB8o%3D&reserved=0
> >> > > > Tree:
> >> > > >
> >> > >
> >> >
> >>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=pIFy%2B9GmevdGztdXijY%2FC%2FBplu1kMuS%2F8BgNjVUFNyI%3D&reserved=0
> >> > > > Diff:
> >> > > >
> >> > >
> >> >
> >>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=eI7HWmaEWDlxbLSw8BKn62gluTSJNPbcfrpLlE92I6E%3D&reserved=0
> >> > > >
> >> > > > Branch: refs/heads/develop
> >> > > > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> >> > > > Parents: eaa33ea
> >> > > > Author: piotrz <pi...@apache.org>
> >> > > > Authored: Sun Jun 25 19:27:09 2017 +0200
> >> > > > Committer: piotrz <pi...@apache.org>
> >> > > > Committed: Sun Jun 25 19:27:09 2017 +0200
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> ----------------------------------------------------------------------
> >> > > >
> >> examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml |
> >> > 2 +-
> >> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> > > >
> >> > >
> >> >
> >>
> ----------------------------------------------------------------------
> >> > > >
> >> > > >
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=xJ19JmLG7vdRC4aur65Jt0RZwCtQ4s8sccXNTjcA5DA%3D&reserved=0
> >> > > >
> >> > >
> >> >
> >>
> ----------------------------------------------------------------------
> >> > > > diff --git
> >> > > >
> a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> >> > > >
> b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> >> > > > index 14d14fd..4231328 100644
> >> > > > ---
> >> > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> >> > > > +++
> >> > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> >> > > > @@ -38,7 +38,7 @@ limitations under the License.
> >> > > > sourceID="menuModel"
> >> > > >
> >> sourcePropertyName="menuItems"
> >> > > >
> >> > destinationPropertyName="dataProvider" />
> >> > > > - <models2:DataFieldProviderModel
> >> > > dataField="value"/>
> >> > > > + <js:DataFieldProviderBead
> >> > dataField="value"/>
> >> > > > </mdl:beads>
> >> > > > </mdl:DropDownList>
> >> > > > </mdl:GridCell>
> >> > > >
> >> > > >
> >> > > >
> >> > > >
> >> > >
> >> > > --
> >> > >
> >> > > Piotr Zarzycki
> >> > >
> >> > > Patreon: *
> >> >
> >>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=%2BLWHpYRKG4Pa1%2FWOH53y%2FVzXQbdm8kTz3%2FGpBW%2FuBow%3D&reserved=0
> >> > > <
> >> >
> >>
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=%2BLWHpYRKG4Pa1%2FWOH53y%2FVzXQbdm8kTz3%2FGpBW%2FuBow%3D&reserved=0
> >> > >*
> >> > >
> >> >
> >> >
> >> > --
> >> > Carlos Rovira
> >> >
> >> >
> >>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856320214&sdata=bEw2aD2IjDggINRA0UgLCESTKyeDd8PAUKQdgvOo%2BiE%3D&reserved=0
> >> >
> >> >
> >> >
> >>
> >> --
> >> Carlos Rovira
> >>
> >>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856320214&sdata=bEw2aD2IjDggINRA0UgLCESTKyeDd8PAUKQdgvOo%2BiE%3D&reserved=0
> >>
> >>
> >>
> >
> > --
> > Carlos Rovira
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856320214&sdata=bEw2aD2IjDggINRA0UgLCESTKyeDd8PAUKQdgvOo%2BiE%3D&reserved=0
> >
> >
>
> --
> Carlos Rovira
>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856320214&sdata=bEw2aD2IjDggINRA0UgLCESTKyeDd8PAUKQdgvOo%2BiE%3D&reserved=0
>
>
>
--
Carlos Rovira
http://about.me/carlosrovira
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Alex Harui <ah...@adobe.com.INVALID>.
I couldn't easily tell if those differences are new features or fixed bugs. Bug fixes that all users of DateChooserModel will need should go in the Basic one. Similarly, the change I made to Jewel's DateChooserModel to fix the build was a quick one. I only added the missing property but didn't hook it up to anything as I don't know if there is Jewel has the same problem or not or can be refactored to leverage more code and the fix from the Basic one.
-Alex
On 1/31/20, 11:04 AM, "Carlos Rovira" <ca...@apache.org> wrote:
About Jewel DateChooserModel, if you compare with Basic one will see that
has several more code, since implements a lot of things that was missed in
the Basic one.
El vie., 31 ene. 2020 a las 19:58, Carlos Rovira (<ca...@apache.org>)
escribió:
> Hi Alex,
>
> the problem is in dataProviderChangeHandler method
> Basic is adding styles just in case like this:
>
> var style:SimpleCSSStyles = new SimpleCSSStyles();
> style.marginBottom = presentationModel.separatorThickness;
> UIBase(ir).style = style;
>
> while Jewel tries to minimize (or remove at all) any set of styles and
> uses CSS
>
> As well
>
> UIBase(ir).percentWidth = 100;
>
> is removed too.
>
> another thing is
>
> dataGroup.addItemRenderer(ir, false);
>
> is executed at in other order in other place, I think I need to do that
> for some reason, but don't remember why
>
> For that reason, I was proposing to refactor to extend the basic one.
>
> What do you think?
>
> El vie., 31 ene. 2020 a las 18:09, Alex Harui (<ah...@adobe.com.invalid>)
> escribió:
>
>> Hi Carlos,
>>
>> The diff I ran didn't show anything obvious. And as you noted in
>> another email, there is a copy of DateChooserModel in Jewel I didn't see
>> that I will fix shortly.
>>
>> Are we still concerned about re-use of Basic beads? I thought all visual
>> CSS from Basic was moved to a Theme. It may also be that we need to get
>> better at using interfaces (and the "has" pattern) and maybe more of these
>> beads and models can go in Core or maybe some other SWC.
>>
>> -Alex
>>
>> On 1/31/20, 4:01 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>>
>> Hi Alex,
>> I've missed this email, sorry. I was comparing code and there's
>> various
>> changes most of all at the end of the file that are important for
>> Jewel,
>> I can try to make it extend the Basic Bead and see if that's possible
>> and
>> saves something
>>
>> El mié., 29 ene. 2020 a las 20:48, Alex Harui
>> (<ah...@adobe.com.invalid>)
>> escribió:
>>
>> > @Carlos,
>> >
>> > While we're on the subject, it appears that Jewel has an actual
>> copy of,
>> > for example, Basic's DataItemRendererFactoryForArrayData. What is
>> the
>> > rationale for that? Is there some subtle difference I'm not seeing
>> or can
>> > we get rid of the duplicate copy?
>> >
>> > -Alex
>> >
>> > On 1/29/20, 8:46 AM, "Carlos Rovira" <ca...@apache.org>
>> wrote:
>> >
>> > It's ok to change it if other changes done this past months
>> make MDL
>> > DDL
>> > continue to work
>> > Maybe others are using it since is a full working set and we
>> should
>> > ensure
>> > it continue to work
>> > thanks
>> >
>> > El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
>> > piotrzarzycki21@gmail.com>) escribió:
>> >
>> > > Hi Alex,
>> > >
>> > > I remember that DropDownl list was lack of dataField actually.
>> > Instead of
>> > > adding it trough property - I have created Bead which
>> provides that
>> > > feature. Whether it's needed now or not is actually something
>> I have
>> > no
>> > > idea about. I'm ok with removing it.
>> > >
>> > >
>> > > wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com>
>> napisał(a):
>> > >
>> > > > Ran into this while doing the has/is refactor.
>> > > >
>> > > > In what ways is this different than the labelField in
>> > IDataProviderModel?
>> > > >
>> > > > Thanks,
>> > > > -Alex
>> > > >
>> > > > On 6/29/17, 12:22 PM, "piotrz@apache.org" <
>> piotrz@apache.org>
>> > wrote:
>> > > >
>> > > > FLEX-35328 - Update MDLExample with
>> DataFieldProviderBead
>> > > >
>> > > >
>> > > > Project:
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=q8gSix2CL6OlUeEMc0S%2FFiYMnL9aleIjEXxXCoG3r94%3D&reserved=0
>> > > > Commit:
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=7eBQKt2xSkYsAkEB6%2BxjOwTG4gagT2NhDR4FkQUvB8o%3D&reserved=0
>> > > > Tree:
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=pIFy%2B9GmevdGztdXijY%2FC%2FBplu1kMuS%2F8BgNjVUFNyI%3D&reserved=0
>> > > > Diff:
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=eI7HWmaEWDlxbLSw8BKn62gluTSJNPbcfrpLlE92I6E%3D&reserved=0
>> > > >
>> > > > Branch: refs/heads/develop
>> > > > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
>> > > > Parents: eaa33ea
>> > > > Author: piotrz <pi...@apache.org>
>> > > > Authored: Sun Jun 25 19:27:09 2017 +0200
>> > > > Committer: piotrz <pi...@apache.org>
>> > > > Committed: Sun Jun 25 19:27:09 2017 +0200
>> > > >
>> > > >
>> > >
>> >
>> ----------------------------------------------------------------------
>> > > >
>> examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml |
>> > 2 +-
>> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > > >
>> > >
>> >
>> ----------------------------------------------------------------------
>> > > >
>> > > >
>> > > >
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=xJ19JmLG7vdRC4aur65Jt0RZwCtQ4s8sccXNTjcA5DA%3D&reserved=0
>> > > >
>> > >
>> >
>> ----------------------------------------------------------------------
>> > > > diff --git
>> > > > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
>> > > > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
>> > > > index 14d14fd..4231328 100644
>> > > > ---
>> > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
>> > > > +++
>> > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
>> > > > @@ -38,7 +38,7 @@ limitations under the License.
>> > > > sourceID="menuModel"
>> > > >
>> sourcePropertyName="menuItems"
>> > > >
>> > destinationPropertyName="dataProvider" />
>> > > > - <models2:DataFieldProviderModel
>> > > dataField="value"/>
>> > > > + <js:DataFieldProviderBead
>> > dataField="value"/>
>> > > > </mdl:beads>
>> > > > </mdl:DropDownList>
>> > > > </mdl:GridCell>
>> > > >
>> > > >
>> > > >
>> > > >
>> > >
>> > > --
>> > >
>> > > Piotr Zarzycki
>> > >
>> > > Patreon: *
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=%2BLWHpYRKG4Pa1%2FWOH53y%2FVzXQbdm8kTz3%2FGpBW%2FuBow%3D&reserved=0
>> > > <
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856310219&sdata=%2BLWHpYRKG4Pa1%2FWOH53y%2FVzXQbdm8kTz3%2FGpBW%2FuBow%3D&reserved=0
>> > >*
>> > >
>> >
>> >
>> > --
>> > Carlos Rovira
>> >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856320214&sdata=bEw2aD2IjDggINRA0UgLCESTKyeDd8PAUKQdgvOo%2BiE%3D&reserved=0
>> >
>> >
>> >
>>
>> --
>> Carlos Rovira
>>
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856320214&sdata=bEw2aD2IjDggINRA0UgLCESTKyeDd8PAUKQdgvOo%2BiE%3D&reserved=0
>>
>>
>>
>
> --
> Carlos Rovira
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856320214&sdata=bEw2aD2IjDggINRA0UgLCESTKyeDd8PAUKQdgvOo%2BiE%3D&reserved=0
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C81a488c7c32049ee65d908d7a6806f02%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160942856320214&sdata=bEw2aD2IjDggINRA0UgLCESTKyeDd8PAUKQdgvOo%2BiE%3D&reserved=0
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Carlos Rovira <ca...@apache.org>.
About Jewel DateChooserModel, if you compare with Basic one will see that
has several more code, since implements a lot of things that was missed in
the Basic one.
El vie., 31 ene. 2020 a las 19:58, Carlos Rovira (<ca...@apache.org>)
escribió:
> Hi Alex,
>
> the problem is in dataProviderChangeHandler method
> Basic is adding styles just in case like this:
>
> var style:SimpleCSSStyles = new SimpleCSSStyles();
> style.marginBottom = presentationModel.separatorThickness;
> UIBase(ir).style = style;
>
> while Jewel tries to minimize (or remove at all) any set of styles and
> uses CSS
>
> As well
>
> UIBase(ir).percentWidth = 100;
>
> is removed too.
>
> another thing is
>
> dataGroup.addItemRenderer(ir, false);
>
> is executed at in other order in other place, I think I need to do that
> for some reason, but don't remember why
>
> For that reason, I was proposing to refactor to extend the basic one.
>
> What do you think?
>
> El vie., 31 ene. 2020 a las 18:09, Alex Harui (<ah...@adobe.com.invalid>)
> escribió:
>
>> Hi Carlos,
>>
>> The diff I ran didn't show anything obvious. And as you noted in
>> another email, there is a copy of DateChooserModel in Jewel I didn't see
>> that I will fix shortly.
>>
>> Are we still concerned about re-use of Basic beads? I thought all visual
>> CSS from Basic was moved to a Theme. It may also be that we need to get
>> better at using interfaces (and the "has" pattern) and maybe more of these
>> beads and models can go in Core or maybe some other SWC.
>>
>> -Alex
>>
>> On 1/31/20, 4:01 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>>
>> Hi Alex,
>> I've missed this email, sorry. I was comparing code and there's
>> various
>> changes most of all at the end of the file that are important for
>> Jewel,
>> I can try to make it extend the Basic Bead and see if that's possible
>> and
>> saves something
>>
>> El mié., 29 ene. 2020 a las 20:48, Alex Harui
>> (<ah...@adobe.com.invalid>)
>> escribió:
>>
>> > @Carlos,
>> >
>> > While we're on the subject, it appears that Jewel has an actual
>> copy of,
>> > for example, Basic's DataItemRendererFactoryForArrayData. What is
>> the
>> > rationale for that? Is there some subtle difference I'm not seeing
>> or can
>> > we get rid of the duplicate copy?
>> >
>> > -Alex
>> >
>> > On 1/29/20, 8:46 AM, "Carlos Rovira" <ca...@apache.org>
>> wrote:
>> >
>> > It's ok to change it if other changes done this past months
>> make MDL
>> > DDL
>> > continue to work
>> > Maybe others are using it since is a full working set and we
>> should
>> > ensure
>> > it continue to work
>> > thanks
>> >
>> > El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
>> > piotrzarzycki21@gmail.com>) escribió:
>> >
>> > > Hi Alex,
>> > >
>> > > I remember that DropDownl list was lack of dataField actually.
>> > Instead of
>> > > adding it trough property - I have created Bead which
>> provides that
>> > > feature. Whether it's needed now or not is actually something
>> I have
>> > no
>> > > idea about. I'm ok with removing it.
>> > >
>> > >
>> > > wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com>
>> napisał(a):
>> > >
>> > > > Ran into this while doing the has/is refactor.
>> > > >
>> > > > In what ways is this different than the labelField in
>> > IDataProviderModel?
>> > > >
>> > > > Thanks,
>> > > > -Alex
>> > > >
>> > > > On 6/29/17, 12:22 PM, "piotrz@apache.org" <
>> piotrz@apache.org>
>> > wrote:
>> > > >
>> > > > FLEX-35328 - Update MDLExample with
>> DataFieldProviderBead
>> > > >
>> > > >
>> > > > Project:
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786949461&sdata=vbGoXe2ruxsudriJpxXTOUi64NZYYMZzME7PrlQ70Mk%3D&reserved=0
>> > > > Commit:
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=uU6V1zehpZ8B7XwhmYuwrn1HxUHDIK%2Fs09xK3CMfXSg%3D&reserved=0
>> > > > Tree:
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=sQlfHhZSf8uCAklIBZqeFS0wmFBTg9nvz%2BAReCZ2MLc%3D&reserved=0
>> > > > Diff:
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=7DBx1rxkufMwiJzNn9Xa5jFSpuzd0D8tX7eHTjlShqw%3D&reserved=0
>> > > >
>> > > > Branch: refs/heads/develop
>> > > > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
>> > > > Parents: eaa33ea
>> > > > Author: piotrz <pi...@apache.org>
>> > > > Authored: Sun Jun 25 19:27:09 2017 +0200
>> > > > Committer: piotrz <pi...@apache.org>
>> > > > Committed: Sun Jun 25 19:27:09 2017 +0200
>> > > >
>> > > >
>> > >
>> >
>> ----------------------------------------------------------------------
>> > > >
>> examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml |
>> > 2 +-
>> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > > >
>> > >
>> >
>> ----------------------------------------------------------------------
>> > > >
>> > > >
>> > > >
>> > > >
>> > >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=kvVGr9plinFIfLQfenH9K3pB4tqWtsx1pvCCnY%2FqX84%3D&reserved=0
>> > > >
>> > >
>> >
>> ----------------------------------------------------------------------
>> > > > diff --git
>> > > > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
>> > > > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
>> > > > index 14d14fd..4231328 100644
>> > > > ---
>> > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
>> > > > +++
>> > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
>> > > > @@ -38,7 +38,7 @@ limitations under the License.
>> > > > sourceID="menuModel"
>> > > >
>> sourcePropertyName="menuItems"
>> > > >
>> > destinationPropertyName="dataProvider" />
>> > > > - <models2:DataFieldProviderModel
>> > > dataField="value"/>
>> > > > + <js:DataFieldProviderBead
>> > dataField="value"/>
>> > > > </mdl:beads>
>> > > > </mdl:DropDownList>
>> > > > </mdl:GridCell>
>> > > >
>> > > >
>> > > >
>> > > >
>> > >
>> > > --
>> > >
>> > > Piotr Zarzycki
>> > >
>> > > Patreon: *
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=n%2BgG6O7D4w21F4umuPE0Dv%2F1sSWLZotUq5G8npg66qI%3D&reserved=0
>> > > <
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=n%2BgG6O7D4w21F4umuPE0Dv%2F1sSWLZotUq5G8npg66qI%3D&reserved=0
>> > >*
>> > >
>> >
>> >
>> > --
>> > Carlos Rovira
>> >
>> >
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=uxXZvzq2WdYozKHIaTJoZfydQkMgQ2wr66DpTxjCX60%3D&reserved=0
>> >
>> >
>> >
>>
>> --
>> Carlos Rovira
>>
>> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=uxXZvzq2WdYozKHIaTJoZfydQkMgQ2wr66DpTxjCX60%3D&reserved=0
>>
>>
>>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Alex Harui <ah...@adobe.com.INVALID>.
I think in the refactor I'm working on it will be easier for Jewel to use the Basic one and alter those few things.
-Alex
On 1/31/20, 10:59 AM, "Carlos Rovira" <ca...@apache.org> wrote:
Hi Alex,
the problem is in dataProviderChangeHandler method
Basic is adding styles just in case like this:
var style:SimpleCSSStyles = new SimpleCSSStyles();
style.marginBottom = presentationModel.separatorThickness;
UIBase(ir).style = style;
while Jewel tries to minimize (or remove at all) any set of styles and uses
CSS
As well
UIBase(ir).percentWidth = 100;
is removed too.
another thing is
dataGroup.addItemRenderer(ir, false);
is executed at in other order in other place, I think I need to do that for
some reason, but don't remember why
For that reason, I was proposing to refactor to extend the basic one.
What do you think?
El vie., 31 ene. 2020 a las 18:09, Alex Harui (<ah...@adobe.com.invalid>)
escribió:
> Hi Carlos,
>
> The diff I ran didn't show anything obvious. And as you noted in another
> email, there is a copy of DateChooserModel in Jewel I didn't see that I
> will fix shortly.
>
> Are we still concerned about re-use of Basic beads? I thought all visual
> CSS from Basic was moved to a Theme. It may also be that we need to get
> better at using interfaces (and the "has" pattern) and maybe more of these
> beads and models can go in Core or maybe some other SWC.
>
> -Alex
>
> On 1/31/20, 4:01 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>
> Hi Alex,
> I've missed this email, sorry. I was comparing code and there's various
> changes most of all at the end of the file that are important for
> Jewel,
> I can try to make it extend the Basic Bead and see if that's possible
> and
> saves something
>
> El mié., 29 ene. 2020 a las 20:48, Alex Harui
> (<ah...@adobe.com.invalid>)
> escribió:
>
> > @Carlos,
> >
> > While we're on the subject, it appears that Jewel has an actual copy
> of,
> > for example, Basic's DataItemRendererFactoryForArrayData. What is
> the
> > rationale for that? Is there some subtle difference I'm not seeing
> or can
> > we get rid of the duplicate copy?
> >
> > -Alex
> >
> > On 1/29/20, 8:46 AM, "Carlos Rovira" <ca...@apache.org>
> wrote:
> >
> > It's ok to change it if other changes done this past months make
> MDL
> > DDL
> > continue to work
> > Maybe others are using it since is a full working set and we
> should
> > ensure
> > it continue to work
> > thanks
> >
> > El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
> > piotrzarzycki21@gmail.com>) escribió:
> >
> > > Hi Alex,
> > >
> > > I remember that DropDownl list was lack of dataField actually.
> > Instead of
> > > adding it trough property - I have created Bead which provides
> that
> > > feature. Whether it's needed now or not is actually something
> I have
> > no
> > > idea about. I'm ok with removing it.
> > >
> > >
> > > wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com>
> napisał(a):
> > >
> > > > Ran into this while doing the has/is refactor.
> > > >
> > > > In what ways is this different than the labelField in
> > IDataProviderModel?
> > > >
> > > > Thanks,
> > > > -Alex
> > > >
> > > > On 6/29/17, 12:22 PM, "piotrz@apache.org" <piotrz@apache.org
> >
> > wrote:
> > > >
> > > > FLEX-35328 - Update MDLExample with DataFieldProviderBead
> > > >
> > > >
> > > > Project:
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=i3HkbrgC70ldpEK9Iz10gR3uqx7c6YtART2MztgHUDk%3D&reserved=0
> > > > Commit:
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=4Li%2B6iFmgCrk3tN80k3YPx00IuI%2BVrQmida539LhTWQ%3D&reserved=0
> > > > Tree:
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=JsqoVpRY065kpLJIjRgjfoW6Uvuwuz1bRvfOmASLpVw%3D&reserved=0
> > > > Diff:
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=fzIoWxBZMCGKliSLxWVfAlNXcItqRpTzORMXmw8rHRU%3D&reserved=0
> > > >
> > > > Branch: refs/heads/develop
> > > > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> > > > Parents: eaa33ea
> > > > Author: piotrz <pi...@apache.org>
> > > > Authored: Sun Jun 25 19:27:09 2017 +0200
> > > > Committer: piotrz <pi...@apache.org>
> > > > Committed: Sun Jun 25 19:27:09 2017 +0200
> > > >
> > > >
> > >
> >
> ----------------------------------------------------------------------
> > > >
> examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml |
> > 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > >
> >
> ----------------------------------------------------------------------
> > > >
> > > >
> > > >
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=V9rZVYuGWDkpdsNdd6HwXGqtyPYv4z4xB%2FvNkMNUMPs%3D&reserved=0
> > > >
> > >
> >
> ----------------------------------------------------------------------
> > > > diff --git
> > > > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > index 14d14fd..4231328 100644
> > > > ---
> > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > +++
> > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > @@ -38,7 +38,7 @@ limitations under the License.
> > > > sourceID="menuModel"
> > > > sourcePropertyName="menuItems"
> > > >
> > destinationPropertyName="dataProvider" />
> > > > - <models2:DataFieldProviderModel
> > > dataField="value"/>
> > > > + <js:DataFieldProviderBead
> > dataField="value"/>
> > > > </mdl:beads>
> > > > </mdl:DropDownList>
> > > > </mdl:GridCell>
> > > >
> > > >
> > > >
> > > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > > Patreon: *
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597048112&sdata=ROxl8Q7DQF6FTj%2FJyS1wx4zF4OjIX2%2Bm%2BBvt5S1PeF8%3D&reserved=0
> > > <
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597058107&sdata=%2F4CI0cQdx%2BBWqZkfQDBMU9GD54XqTqc%2FO7VuymE1IZs%3D&reserved=0
> > >*
> > >
> >
> >
> > --
> > Carlos Rovira
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597058107&sdata=YnoJ8VomKpTSH1%2F2%2B0GSuvNHZVHqHk47LfvhwvasUac%3D&reserved=0
> >
> >
> >
>
> --
> Carlos Rovira
>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597058107&sdata=YnoJ8VomKpTSH1%2F2%2B0GSuvNHZVHqHk47LfvhwvasUac%3D&reserved=0
>
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Ca6a4c75b230049f80b4e08d7a67fac93%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160939597058107&sdata=YnoJ8VomKpTSH1%2F2%2B0GSuvNHZVHqHk47LfvhwvasUac%3D&reserved=0
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Carlos Rovira <ca...@apache.org>.
Hi Alex,
the problem is in dataProviderChangeHandler method
Basic is adding styles just in case like this:
var style:SimpleCSSStyles = new SimpleCSSStyles();
style.marginBottom = presentationModel.separatorThickness;
UIBase(ir).style = style;
while Jewel tries to minimize (or remove at all) any set of styles and uses
CSS
As well
UIBase(ir).percentWidth = 100;
is removed too.
another thing is
dataGroup.addItemRenderer(ir, false);
is executed at in other order in other place, I think I need to do that for
some reason, but don't remember why
For that reason, I was proposing to refactor to extend the basic one.
What do you think?
El vie., 31 ene. 2020 a las 18:09, Alex Harui (<ah...@adobe.com.invalid>)
escribió:
> Hi Carlos,
>
> The diff I ran didn't show anything obvious. And as you noted in another
> email, there is a copy of DateChooserModel in Jewel I didn't see that I
> will fix shortly.
>
> Are we still concerned about re-use of Basic beads? I thought all visual
> CSS from Basic was moved to a Theme. It may also be that we need to get
> better at using interfaces (and the "has" pattern) and maybe more of these
> beads and models can go in Core or maybe some other SWC.
>
> -Alex
>
> On 1/31/20, 4:01 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>
> Hi Alex,
> I've missed this email, sorry. I was comparing code and there's various
> changes most of all at the end of the file that are important for
> Jewel,
> I can try to make it extend the Basic Bead and see if that's possible
> and
> saves something
>
> El mié., 29 ene. 2020 a las 20:48, Alex Harui
> (<ah...@adobe.com.invalid>)
> escribió:
>
> > @Carlos,
> >
> > While we're on the subject, it appears that Jewel has an actual copy
> of,
> > for example, Basic's DataItemRendererFactoryForArrayData. What is
> the
> > rationale for that? Is there some subtle difference I'm not seeing
> or can
> > we get rid of the duplicate copy?
> >
> > -Alex
> >
> > On 1/29/20, 8:46 AM, "Carlos Rovira" <ca...@apache.org>
> wrote:
> >
> > It's ok to change it if other changes done this past months make
> MDL
> > DDL
> > continue to work
> > Maybe others are using it since is a full working set and we
> should
> > ensure
> > it continue to work
> > thanks
> >
> > El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
> > piotrzarzycki21@gmail.com>) escribió:
> >
> > > Hi Alex,
> > >
> > > I remember that DropDownl list was lack of dataField actually.
> > Instead of
> > > adding it trough property - I have created Bead which provides
> that
> > > feature. Whether it's needed now or not is actually something
> I have
> > no
> > > idea about. I'm ok with removing it.
> > >
> > >
> > > wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com>
> napisał(a):
> > >
> > > > Ran into this while doing the has/is refactor.
> > > >
> > > > In what ways is this different than the labelField in
> > IDataProviderModel?
> > > >
> > > > Thanks,
> > > > -Alex
> > > >
> > > > On 6/29/17, 12:22 PM, "piotrz@apache.org" <piotrz@apache.org
> >
> > wrote:
> > > >
> > > > FLEX-35328 - Update MDLExample with DataFieldProviderBead
> > > >
> > > >
> > > > Project:
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786949461&sdata=vbGoXe2ruxsudriJpxXTOUi64NZYYMZzME7PrlQ70Mk%3D&reserved=0
> > > > Commit:
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=uU6V1zehpZ8B7XwhmYuwrn1HxUHDIK%2Fs09xK3CMfXSg%3D&reserved=0
> > > > Tree:
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=sQlfHhZSf8uCAklIBZqeFS0wmFBTg9nvz%2BAReCZ2MLc%3D&reserved=0
> > > > Diff:
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=7DBx1rxkufMwiJzNn9Xa5jFSpuzd0D8tX7eHTjlShqw%3D&reserved=0
> > > >
> > > > Branch: refs/heads/develop
> > > > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> > > > Parents: eaa33ea
> > > > Author: piotrz <pi...@apache.org>
> > > > Authored: Sun Jun 25 19:27:09 2017 +0200
> > > > Committer: piotrz <pi...@apache.org>
> > > > Committed: Sun Jun 25 19:27:09 2017 +0200
> > > >
> > > >
> > >
> >
> ----------------------------------------------------------------------
> > > >
> examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml |
> > 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > >
> >
> ----------------------------------------------------------------------
> > > >
> > > >
> > > >
> > > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=kvVGr9plinFIfLQfenH9K3pB4tqWtsx1pvCCnY%2FqX84%3D&reserved=0
> > > >
> > >
> >
> ----------------------------------------------------------------------
> > > > diff --git
> > > > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > index 14d14fd..4231328 100644
> > > > ---
> > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > +++
> > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > > @@ -38,7 +38,7 @@ limitations under the License.
> > > > sourceID="menuModel"
> > > > sourcePropertyName="menuItems"
> > > >
> > destinationPropertyName="dataProvider" />
> > > > - <models2:DataFieldProviderModel
> > > dataField="value"/>
> > > > + <js:DataFieldProviderBead
> > dataField="value"/>
> > > > </mdl:beads>
> > > > </mdl:DropDownList>
> > > > </mdl:GridCell>
> > > >
> > > >
> > > >
> > > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > > Patreon: *
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=n%2BgG6O7D4w21F4umuPE0Dv%2F1sSWLZotUq5G8npg66qI%3D&reserved=0
> > > <
> >
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=n%2BgG6O7D4w21F4umuPE0Dv%2F1sSWLZotUq5G8npg66qI%3D&reserved=0
> > >*
> > >
> >
> >
> > --
> > Carlos Rovira
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=uxXZvzq2WdYozKHIaTJoZfydQkMgQ2wr66DpTxjCX60%3D&reserved=0
> >
> >
> >
>
> --
> Carlos Rovira
>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=uxXZvzq2WdYozKHIaTJoZfydQkMgQ2wr66DpTxjCX60%3D&reserved=0
>
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Hi Carlos,
The diff I ran didn't show anything obvious. And as you noted in another email, there is a copy of DateChooserModel in Jewel I didn't see that I will fix shortly.
Are we still concerned about re-use of Basic beads? I thought all visual CSS from Basic was moved to a Theme. It may also be that we need to get better at using interfaces (and the "has" pattern) and maybe more of these beads and models can go in Core or maybe some other SWC.
-Alex
On 1/31/20, 4:01 AM, "Carlos Rovira" <ca...@apache.org> wrote:
Hi Alex,
I've missed this email, sorry. I was comparing code and there's various
changes most of all at the end of the file that are important for Jewel,
I can try to make it extend the Basic Bead and see if that's possible and
saves something
El mié., 29 ene. 2020 a las 20:48, Alex Harui (<ah...@adobe.com.invalid>)
escribió:
> @Carlos,
>
> While we're on the subject, it appears that Jewel has an actual copy of,
> for example, Basic's DataItemRendererFactoryForArrayData. What is the
> rationale for that? Is there some subtle difference I'm not seeing or can
> we get rid of the duplicate copy?
>
> -Alex
>
> On 1/29/20, 8:46 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>
> It's ok to change it if other changes done this past months make MDL
> DDL
> continue to work
> Maybe others are using it since is a full working set and we should
> ensure
> it continue to work
> thanks
>
> El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
> piotrzarzycki21@gmail.com>) escribió:
>
> > Hi Alex,
> >
> > I remember that DropDownl list was lack of dataField actually.
> Instead of
> > adding it trough property - I have created Bead which provides that
> > feature. Whether it's needed now or not is actually something I have
> no
> > idea about. I'm ok with removing it.
> >
> >
> > wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com> napisał(a):
> >
> > > Ran into this while doing the has/is refactor.
> > >
> > > In what ways is this different than the labelField in
> IDataProviderModel?
> > >
> > > Thanks,
> > > -Alex
> > >
> > > On 6/29/17, 12:22 PM, "piotrz@apache.org" <pi...@apache.org>
> wrote:
> > >
> > > FLEX-35328 - Update MDLExample with DataFieldProviderBead
> > >
> > >
> > > Project:
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786949461&sdata=vbGoXe2ruxsudriJpxXTOUi64NZYYMZzME7PrlQ70Mk%3D&reserved=0
> > > Commit:
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=uU6V1zehpZ8B7XwhmYuwrn1HxUHDIK%2Fs09xK3CMfXSg%3D&reserved=0
> > > Tree:
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=sQlfHhZSf8uCAklIBZqeFS0wmFBTg9nvz%2BAReCZ2MLc%3D&reserved=0
> > > Diff:
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=7DBx1rxkufMwiJzNn9Xa5jFSpuzd0D8tX7eHTjlShqw%3D&reserved=0
> > >
> > > Branch: refs/heads/develop
> > > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> > > Parents: eaa33ea
> > > Author: piotrz <pi...@apache.org>
> > > Authored: Sun Jun 25 19:27:09 2017 +0200
> > > Committer: piotrz <pi...@apache.org>
> > > Committed: Sun Jun 25 19:27:09 2017 +0200
> > >
> > >
> >
> ----------------------------------------------------------------------
> > > examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml |
> 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> ----------------------------------------------------------------------
> > >
> > >
> > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=kvVGr9plinFIfLQfenH9K3pB4tqWtsx1pvCCnY%2FqX84%3D&reserved=0
> > >
> >
> ----------------------------------------------------------------------
> > > diff --git
> > > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > index 14d14fd..4231328 100644
> > > ---
> a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > +++
> b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > @@ -38,7 +38,7 @@ limitations under the License.
> > > sourceID="menuModel"
> > > sourcePropertyName="menuItems"
> > >
> destinationPropertyName="dataProvider" />
> > > - <models2:DataFieldProviderModel
> > dataField="value"/>
> > > + <js:DataFieldProviderBead
> dataField="value"/>
> > > </mdl:beads>
> > > </mdl:DropDownList>
> > > </mdl:GridCell>
> > >
> > >
> > >
> > >
> >
> > --
> >
> > Piotr Zarzycki
> >
> > Patreon: *
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=n%2BgG6O7D4w21F4umuPE0Dv%2F1sSWLZotUq5G8npg66qI%3D&reserved=0
> > <
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=n%2BgG6O7D4w21F4umuPE0Dv%2F1sSWLZotUq5G8npg66qI%3D&reserved=0
> >*
> >
>
>
> --
> Carlos Rovira
>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=uxXZvzq2WdYozKHIaTJoZfydQkMgQ2wr66DpTxjCX60%3D&reserved=0
>
>
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C592a604967864eb0e11708d7a64546e5%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637160688786959455&sdata=uxXZvzq2WdYozKHIaTJoZfydQkMgQ2wr66DpTxjCX60%3D&reserved=0
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Carlos Rovira <ca...@apache.org>.
Hi Alex,
I've missed this email, sorry. I was comparing code and there's various
changes most of all at the end of the file that are important for Jewel,
I can try to make it extend the Basic Bead and see if that's possible and
saves something
El mié., 29 ene. 2020 a las 20:48, Alex Harui (<ah...@adobe.com.invalid>)
escribió:
> @Carlos,
>
> While we're on the subject, it appears that Jewel has an actual copy of,
> for example, Basic's DataItemRendererFactoryForArrayData. What is the
> rationale for that? Is there some subtle difference I'm not seeing or can
> we get rid of the duplicate copy?
>
> -Alex
>
> On 1/29/20, 8:46 AM, "Carlos Rovira" <ca...@apache.org> wrote:
>
> It's ok to change it if other changes done this past months make MDL
> DDL
> continue to work
> Maybe others are using it since is a full working set and we should
> ensure
> it continue to work
> thanks
>
> El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
> piotrzarzycki21@gmail.com>) escribió:
>
> > Hi Alex,
> >
> > I remember that DropDownl list was lack of dataField actually.
> Instead of
> > adding it trough property - I have created Bead which provides that
> > feature. Whether it's needed now or not is actually something I have
> no
> > idea about. I'm ok with removing it.
> >
> >
> > wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com> napisał(a):
> >
> > > Ran into this while doing the has/is refactor.
> > >
> > > In what ways is this different than the labelField in
> IDataProviderModel?
> > >
> > > Thanks,
> > > -Alex
> > >
> > > On 6/29/17, 12:22 PM, "piotrz@apache.org" <pi...@apache.org>
> wrote:
> > >
> > > FLEX-35328 - Update MDLExample with DataFieldProviderBead
> > >
> > >
> > > Project:
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175331931&sdata=o8vCSEU8b3I95JDWtA2Cwp%2FKxzCizNP4ozJVYigIPeA%3D&reserved=0
> > > Commit:
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175331931&sdata=aRtlOlZBqgPbmYDnWKCudbvgGQ%2BiTT3SXfSwlcZOfTU%3D&reserved=0
> > > Tree:
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175331931&sdata=rOgVJyXLul7KmWwekXkQ5fybxByoTXtDzz%2B%2BcRcM47c%3D&reserved=0
> > > Diff:
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=vKp2yoZLcsqigRsNKO46lbwYY3339EXXokY8V7VtMRM%3D&reserved=0
> > >
> > > Branch: refs/heads/develop
> > > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> > > Parents: eaa33ea
> > > Author: piotrz <pi...@apache.org>
> > > Authored: Sun Jun 25 19:27:09 2017 +0200
> > > Committer: piotrz <pi...@apache.org>
> > > Committed: Sun Jun 25 19:27:09 2017 +0200
> > >
> > >
> >
> ----------------------------------------------------------------------
> > > examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml |
> 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> >
> ----------------------------------------------------------------------
> > >
> > >
> > >
> > >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=A6jnQEpZw7WeUjive%2BZN53CAIkFKJr8orsVb1FO5YqE%3D&reserved=0
> > >
> >
> ----------------------------------------------------------------------
> > > diff --git
> > > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > index 14d14fd..4231328 100644
> > > ---
> a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > +++
> b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > > @@ -38,7 +38,7 @@ limitations under the License.
> > > sourceID="menuModel"
> > > sourcePropertyName="menuItems"
> > >
> destinationPropertyName="dataProvider" />
> > > - <models2:DataFieldProviderModel
> > dataField="value"/>
> > > + <js:DataFieldProviderBead
> dataField="value"/>
> > > </mdl:beads>
> > > </mdl:DropDownList>
> > > </mdl:GridCell>
> > >
> > >
> > >
> > >
> >
> > --
> >
> > Piotr Zarzycki
> >
> > Patreon: *
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=4lZCGAtgbXbeXA0ZfpEhiHeN4zRz3r6T2i5Uq0GmhQA%3D&reserved=0
> > <
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=4lZCGAtgbXbeXA0ZfpEhiHeN4zRz3r6T2i5Uq0GmhQA%3D&reserved=0
> >*
> >
>
>
> --
> Carlos Rovira
>
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=6WsDz42ckjU3qbK%2FggLU%2Fmsi%2B0cT48GjmXT7FHjiJ54%3D&reserved=0
>
>
>
--
Carlos Rovira
http://about.me/carlosrovira
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Alex Harui <ah...@adobe.com.INVALID>.
@Carlos,
While we're on the subject, it appears that Jewel has an actual copy of, for example, Basic's DataItemRendererFactoryForArrayData. What is the rationale for that? Is there some subtle difference I'm not seeing or can we get rid of the duplicate copy?
-Alex
On 1/29/20, 8:46 AM, "Carlos Rovira" <ca...@apache.org> wrote:
It's ok to change it if other changes done this past months make MDL DDL
continue to work
Maybe others are using it since is a full working set and we should ensure
it continue to work
thanks
El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
piotrzarzycki21@gmail.com>) escribió:
> Hi Alex,
>
> I remember that DropDownl list was lack of dataField actually. Instead of
> adding it trough property - I have created Bead which provides that
> feature. Whether it's needed now or not is actually something I have no
> idea about. I'm ok with removing it.
>
>
> wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com> napisał(a):
>
> > Ran into this while doing the has/is refactor.
> >
> > In what ways is this different than the labelField in IDataProviderModel?
> >
> > Thanks,
> > -Alex
> >
> > On 6/29/17, 12:22 PM, "piotrz@apache.org" <pi...@apache.org> wrote:
> >
> > FLEX-35328 - Update MDLExample with DataFieldProviderBead
> >
> >
> > Project:
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175331931&sdata=o8vCSEU8b3I95JDWtA2Cwp%2FKxzCizNP4ozJVYigIPeA%3D&reserved=0
> > Commit:
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175331931&sdata=aRtlOlZBqgPbmYDnWKCudbvgGQ%2BiTT3SXfSwlcZOfTU%3D&reserved=0
> > Tree:
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175331931&sdata=rOgVJyXLul7KmWwekXkQ5fybxByoTXtDzz%2B%2BcRcM47c%3D&reserved=0
> > Diff:
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=vKp2yoZLcsqigRsNKO46lbwYY3339EXXokY8V7VtMRM%3D&reserved=0
> >
> > Branch: refs/heads/develop
> > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> > Parents: eaa33ea
> > Author: piotrz <pi...@apache.org>
> > Authored: Sun Jun 25 19:27:09 2017 +0200
> > Committer: piotrz <pi...@apache.org>
> > Committed: Sun Jun 25 19:27:09 2017 +0200
> >
> >
> ----------------------------------------------------------------------
> > examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> ----------------------------------------------------------------------
> >
> >
> >
> >
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=A6jnQEpZw7WeUjive%2BZN53CAIkFKJr8orsVb1FO5YqE%3D&reserved=0
> >
> ----------------------------------------------------------------------
> > diff --git
> > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > index 14d14fd..4231328 100644
> > --- a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > +++ b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > @@ -38,7 +38,7 @@ limitations under the License.
> > sourceID="menuModel"
> > sourcePropertyName="menuItems"
> > destinationPropertyName="dataProvider" />
> > - <models2:DataFieldProviderModel
> dataField="value"/>
> > + <js:DataFieldProviderBead dataField="value"/>
> > </mdl:beads>
> > </mdl:DropDownList>
> > </mdl:GridCell>
> >
> >
> >
> >
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=4lZCGAtgbXbeXA0ZfpEhiHeN4zRz3r6T2i5Uq0GmhQA%3D&reserved=0
> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=4lZCGAtgbXbeXA0ZfpEhiHeN4zRz3r6T2i5Uq0GmhQA%3D&reserved=0>*
>
--
Carlos Rovira
https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C90cd166f2afe4db321f408d7a4dad9b7%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637159132175341924&sdata=6WsDz42ckjU3qbK%2FggLU%2Fmsi%2B0cT48GjmXT7FHjiJ54%3D&reserved=0
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Carlos Rovira <ca...@apache.org>.
It's ok to change it if other changes done this past months make MDL DDL
continue to work
Maybe others are using it since is a full working set and we should ensure
it continue to work
thanks
El mié., 29 ene. 2020 a las 15:56, Piotr Zarzycki (<
piotrzarzycki21@gmail.com>) escribió:
> Hi Alex,
>
> I remember that DropDownl list was lack of dataField actually. Instead of
> adding it trough property - I have created Bead which provides that
> feature. Whether it's needed now or not is actually something I have no
> idea about. I'm ok with removing it.
>
>
> wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com> napisał(a):
>
> > Ran into this while doing the has/is refactor.
> >
> > In what ways is this different than the labelField in IDataProviderModel?
> >
> > Thanks,
> > -Alex
> >
> > On 6/29/17, 12:22 PM, "piotrz@apache.org" <pi...@apache.org> wrote:
> >
> > FLEX-35328 - Update MDLExample with DataFieldProviderBead
> >
> >
> > Project:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=BE4Z7ZcUMq%2FhFpeKmsQUAeqzgHHQ4fBT5JKJGOAQXLQ%3D&reserved=0
> > Commit:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=18wyjAOAvTeMBC41hZK32BZ5yEBwL0q3eY6aOedltVo%3D&reserved=0
> > Tree:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=oizDT4asGP%2F3V4FKy2otyMW5PqmufwThJblkaC2YmKk%3D&reserved=0
> > Diff:
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=gadfSlqR%2BTh%2F5pirsxkEvSjF9PnrZO2mlIlhlWiNrpY%3D&reserved=0
> >
> > Branch: refs/heads/develop
> > Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> > Parents: eaa33ea
> > Author: piotrz <pi...@apache.org>
> > Authored: Sun Jun 25 19:27:09 2017 +0200
> > Committer: piotrz <pi...@apache.org>
> > Committed: Sun Jun 25 19:27:09 2017 +0200
> >
> >
> ----------------------------------------------------------------------
> > examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> ----------------------------------------------------------------------
> >
> >
> >
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=QBzrdEaKyzEBxXfodisqDQFthzf0%2FXwKB6GE22q9c2Y%3D&reserved=0
> >
> ----------------------------------------------------------------------
> > diff --git
> > a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > index 14d14fd..4231328 100644
> > --- a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > +++ b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> > @@ -38,7 +38,7 @@ limitations under the License.
> > sourceID="menuModel"
> > sourcePropertyName="menuItems"
> > destinationPropertyName="dataProvider" />
> > - <models2:DataFieldProviderModel
> dataField="value"/>
> > + <js:DataFieldProviderBead dataField="value"/>
> > </mdl:beads>
> > </mdl:DropDownList>
> > </mdl:GridCell>
> >
> >
> >
> >
>
> --
>
> Piotr Zarzycki
>
> Patreon: *https://www.patreon.com/piotrzarzycki
> <https://www.patreon.com/piotrzarzycki>*
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [19/23] git commit: [flex-asjs] [refs/heads/develop] - FLEX-35328
- Update MDLExample with DataFieldProviderBead
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Alex,
I remember that DropDownl list was lack of dataField actually. Instead of
adding it trough property - I have created Bead which provides that
feature. Whether it's needed now or not is actually something I have no
idea about. I'm ok with removing it.
wt., 28 sty 2020 o 20:55 Alex Harui <ah...@adobe.com> napisał(a):
> Ran into this while doing the has/is refactor.
>
> In what ways is this different than the labelField in IDataProviderModel?
>
> Thanks,
> -Alex
>
> On 6/29/17, 12:22 PM, "piotrz@apache.org" <pi...@apache.org> wrote:
>
> FLEX-35328 - Update MDLExample with DataFieldProviderBead
>
>
> Project:
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=BE4Z7ZcUMq%2FhFpeKmsQUAeqzgHHQ4fBT5JKJGOAQXLQ%3D&reserved=0
> Commit:
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=18wyjAOAvTeMBC41hZK32BZ5yEBwL0q3eY6aOedltVo%3D&reserved=0
> Tree:
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=oizDT4asGP%2F3V4FKy2otyMW5PqmufwThJblkaC2YmKk%3D&reserved=0
> Diff:
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc706278e&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=gadfSlqR%2BTh%2F5pirsxkEvSjF9PnrZO2mlIlhlWiNrpY%3D&reserved=0
>
> Branch: refs/heads/develop
> Commit: c706278ed1fe5d7ab5e763c572b3d97f16077a80
> Parents: eaa33ea
> Author: piotrz <pi...@apache.org>
> Authored: Sun Jun 25 19:27:09 2017 +0200
> Committer: piotrz <pi...@apache.org>
> Committed: Sun Jun 25 19:27:09 2017 +0200
>
> ----------------------------------------------------------------------
> examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
>
> https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc706278e%2Fexamples%2Fflexjs%2FMDLExample%2Fsrc%2Fmain%2Fflex%2FDropDownList.mxml&data=02%7C01%7C%7Ce9a025206cd1484d5b5808d4bf2435e8%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636343609641818561&sdata=QBzrdEaKyzEBxXfodisqDQFthzf0%2FXwKB6GE22q9c2Y%3D&reserved=0
> ----------------------------------------------------------------------
> diff --git
> a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> index 14d14fd..4231328 100644
> --- a/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> +++ b/examples/flexjs/MDLExample/src/main/flex/DropDownList.mxml
> @@ -38,7 +38,7 @@ limitations under the License.
> sourceID="menuModel"
> sourcePropertyName="menuItems"
> destinationPropertyName="dataProvider" />
> - <models2:DataFieldProviderModel dataField="value"/>
> + <js:DataFieldProviderBead dataField="value"/>
> </mdl:beads>
> </mdl:DropDownList>
> </mdl:GridCell>
>
>
>
>
--
Piotr Zarzycki
Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*
New comment - [#433965] Re: [19/23] git commit: [flex-asjs]
[refs/heads/develop] - FLEX-35328 - Update MDLExample with
DataFieldProviderBead
Posted by STRIPL | SUPPORT <su...@smsgatewayhub.com>.
There is a new comment in the ticket submitted by Dev to STRIPL SUPPORT Comment added by : Dev Comment Content: <div></div>