You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tez.apache.org by GitBox <gi...@apache.org> on 2021/01/19 20:45:55 UTC
[GitHub] [tez] belugabehr opened a new pull request #87: TEZ-4095: Review of Debug Logging
belugabehr opened a new pull request #87:
URL: https://github.com/apache/tez/pull/87
Trying this again, albeit as a GitHub PR and, for simplicity, I tried to only "fix" debug statements that do not require much modification
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles merged pull request #87: TEZ-4095: Review of Debug Logging
Posted by GitBox <gi...@apache.org>.
jteagles merged pull request #87:
URL: https://github.com/apache/tez/pull/87
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles commented on a change in pull request #87: TEZ-4095: Review of Debug Logging
Posted by GitBox <gi...@apache.org>.
jteagles commented on a change in pull request #87:
URL: https://github.com/apache/tez/pull/87#discussion_r561287795
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/rm/DagAwareYarnTaskScheduler.java
##########
@@ -743,7 +743,7 @@ public float getProgress() {
++numHeartbeats;
if (LOG.isDebugEnabled() || numHeartbeats % 50 == 1) {
- LOG.info(constructPeriodicLog(freeResources));
+ LOG.debug(constructPeriodicLog(freeResources));
Review comment:
This is a new change from the previous patch and a good catch that has been there since this file was created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles merged pull request #87: TEZ-4095: Review of Debug Logging
Posted by GitBox <gi...@apache.org>.
jteagles merged pull request #87:
URL: https://github.com/apache/tez/pull/87
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] jteagles commented on a change in pull request #87: TEZ-4095: Review of Debug Logging
Posted by GitBox <gi...@apache.org>.
jteagles commented on a change in pull request #87:
URL: https://github.com/apache/tez/pull/87#discussion_r561287795
##########
File path: tez-dag/src/main/java/org/apache/tez/dag/app/rm/DagAwareYarnTaskScheduler.java
##########
@@ -743,7 +743,7 @@ public float getProgress() {
++numHeartbeats;
if (LOG.isDebugEnabled() || numHeartbeats % 50 == 1) {
- LOG.info(constructPeriodicLog(freeResources));
+ LOG.debug(constructPeriodicLog(freeResources));
Review comment:
This is a new change from the previous patch and a good catch that has been there since this file was created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] belugabehr commented on pull request #87: TEZ-4095: Review of Debug Logging
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #87:
URL: https://github.com/apache/tez/pull/87#issuecomment-765056795
@jteagles @abstractdog Thanks for the review (twice for @jteagles) and the merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tez] belugabehr commented on pull request #87: TEZ-4095: Review of Debug Logging
Posted by GitBox <gi...@apache.org>.
belugabehr commented on pull request #87:
URL: https://github.com/apache/tez/pull/87#issuecomment-765056795
@jteagles @abstractdog Thanks for the review (twice for @jteagles) and the merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org