You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2018/09/06 10:37:33 UTC

[Impala-ASF-CR] IMPALA-7542: find-fragment-instances misses to find the "root threads"

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11396


Change subject: IMPALA-7542: find-fragment-instances misses to find the "root threads"
......................................................................

IMPALA-7542: find-fragment-instances misses to find the "root threads"

find-fragment-instances didn't show all the threads
that worked on some fragment instance. It was because
it checked the fragment instance of the parent thread
instead of the actual thread, therefore missing the
"root threads" that started working on the fragment
instance.

I modified the get_fragment_instances() function to
check the local ThreadDebugInfo object of the threads.

I tested it locally on a core file.

Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6
---
M lib/python/impala_py_lib/gdb/impala-gdb.py
1 file changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/11396/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6
Gerrit-Change-Number: 11396
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7542: fix find-fragment-instances to find all "root threads"

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.

Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11396 )

Change subject: IMPALA-7542: fix find-fragment-instances to find all "root threads"
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6
Gerrit-Change-Number: 11396
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Sep 2018 20:40:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7542: fix find-fragment-instances to find all "root threads"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11396 )

Change subject: IMPALA-7542: fix find-fragment-instances to find all "root threads"
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3133/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6
Gerrit-Change-Number: 11396
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Sep 2018 20:40:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7542: fix find-fragment-instances to find all "root threads"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11396 )

Change subject: IMPALA-7542: fix find-fragment-instances to find all "root threads"
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/613/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6
Gerrit-Change-Number: 11396
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Sep 2018 10:11:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7542: fix find-fragment-instances to find all "root threads"

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.

Hello Lars Volker, Zoram Thanga, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11396

to look at the new patch set (#2).

Change subject: IMPALA-7542: fix find-fragment-instances to find all "root threads"
......................................................................

IMPALA-7542: fix find-fragment-instances to find all "root threads"

find-fragment-instances didn't show all the threads
that worked on some fragment instance. It missed the
top-level "root threads" that started working on the
fragment instances.

I modified the get_fragment_instances() function to
check the local ThreadDebugInfo object of the threads
instead of checking the parent thread's ThreadDebugInfo.

I tested it locally on a core file.

Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6
---
M lib/python/impala_py_lib/gdb/impala-gdb.py
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/11396/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6
Gerrit-Change-Number: 11396
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7542: fix find-fragment-instances to find all "root threads"

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11396 )

Change subject: IMPALA-7542: fix find-fragment-instances to find all "root threads"
......................................................................

IMPALA-7542: fix find-fragment-instances to find all "root threads"

find-fragment-instances didn't show all the threads
that worked on some fragment instance. It missed the
top-level "root threads" that started working on the
fragment instances.

I modified the get_fragment_instances() function to
check the local ThreadDebugInfo object of the threads
instead of checking the parent thread's ThreadDebugInfo.

I tested it locally on a core file.

Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6
Reviewed-on: http://gerrit.cloudera.org:8080/11396
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M lib/python/impala_py_lib/gdb/impala-gdb.py
1 file changed, 5 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I35ae1a6b384b002b343689469f02ceabd84af1b6
Gerrit-Change-Number: 11396
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>