You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Micah Kornfield (JIRA)" <ji...@apache.org> on 2019/07/12 08:41:00 UTC
[jira] [Commented] (ARROW-5918) [Java] Revise the BaseIntVector
interface
[ https://issues.apache.org/jira/browse/ARROW-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883626#comment-16883626 ]
Micah Kornfield commented on ARROW-5918:
----------------------------------------
For #1, the baseIntVector isn't just for dictionaries, its a general interface which is why it was changed to long.
> [Java] Revise the BaseIntVector interface
> -----------------------------------------
>
> Key: ARROW-5918
> URL: https://issues.apache.org/jira/browse/ARROW-5918
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java
> Reporter: Liya Fan
> Assignee: Ji Liu
> Priority: Minor
>
> 1. In the set method should not use long as parameter. It is hardly the case that there are more than 2^32 distinct values in a dictionary. If it really happens, maybe it means we should not have used dictionary in the first place.
> 2. In addition to the get method, there should also be a set method.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)