You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@reef.apache.org by "Mariia Mykhailova (JIRA)" <ji...@apache.org> on 2015/12/11 01:49:11 UTC

[jira] [Updated] (REEF-1055) Enable StyleCop.CSharp.ReadabilityRules and fix violations

     [ https://issues.apache.org/jira/browse/REEF-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mariia Mykhailova updated REEF-1055:
------------------------------------
    Description: 
I suggest we adopt all rules, except:

* SA1101: PrefixLocalCallsWithThis and SA1126: PrefixCallsCorrectly which require that we add {{this.}} whenever we reference class member. For similar issue in Java we decided against it.
* SA1115: ParameterMustFollowComma which produces lots of violations which look like false positives (we don't have empty lines in lists of parametes).

  was:We need to examine rules in this group, enforce the ones that match our coding style and fix their violations, and delete the ones we don't want to adopt.


> Enable StyleCop.CSharp.ReadabilityRules and fix violations
> ----------------------------------------------------------
>
>                 Key: REEF-1055
>                 URL: https://issues.apache.org/jira/browse/REEF-1055
>             Project: REEF
>          Issue Type: Sub-task
>          Components: REEF.NET
>            Reporter: Mariia Mykhailova
>            Priority: Minor
>
> I suggest we adopt all rules, except:
> * SA1101: PrefixLocalCallsWithThis and SA1126: PrefixCallsCorrectly which require that we add {{this.}} whenever we reference class member. For similar issue in Java we decided against it.
> * SA1115: ParameterMustFollowComma which produces lots of violations which look like false positives (we don't have empty lines in lists of parametes).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)