You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/12 22:55:18 UTC
[GitHub] [spark-website] fredster33 opened a new pull request #353: Grammar fix, improve PR template
fredster33 opened a new pull request #353:
URL: https://github.com/apache/spark-website/pull/353
By commenting it out, it will still appear when somebody starts a PR, but then they do not need to remove it, as it will be gone after saving (but it is still visible when editing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] fredster33 commented on a change in pull request #353: Grammar fix, improve PR template
Posted by GitBox <gi...@apache.org>.
fredster33 commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688143127
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request also. See README.md for more information. Please remove this message.*
+<!-- *Make sure that you generate site HTML with `bundle exec jekyll build`, and explain the changes to the HTML in your pull request. See README.md for more information.* -->
Review comment:
Oh, all right. I'll replace explain with include.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen commented on a change in pull request #353: Grammar fix, improve PR template
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688140435
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request also. See README.md for more information. Please remove this message.*
+<!-- *Make sure that you generate site HTML with `bundle exec jekyll build`, and explain the changes to the HTML in your pull request. See README.md for more information.* -->
Review comment:
I think 'include' was intended here. Rest seems OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] fredster33 commented on a change in pull request #353: Grammar fix, improve PR template
Posted by GitBox <gi...@apache.org>.
fredster33 commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688140993
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request also. See README.md for more information. Please remove this message.*
+<!-- *Make sure that you generate site HTML with `bundle exec jekyll build`, and explain the changes to the HTML in your pull request. See README.md for more information.* -->
Review comment:
Personally I think "include" is less clear than "explain", when in the same sentence as the bundle command, since it sounds like it's talking about the command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] HyukjinKwon commented on a change in pull request #353: Grammar fix, improve PR template
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688174979
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request also. See README.md for more information. Please remove this message.*
+<!-- *Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request. See README.md for more information.* -->
Review comment:
```suggestion
<!-- Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request. See README.md for more information. -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen closed pull request #353: Grammar fix, improve PR template
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #353:
URL: https://github.com/apache/spark-website/pull/353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
[GitHub] [spark-website] srowen commented on a change in pull request #353: Grammar fix, improve PR template
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #353:
URL: https://github.com/apache/spark-website/pull/353#discussion_r688142555
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -1 +1 @@
-*Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request also. See README.md for more information. Please remove this message.*
+<!-- *Make sure that you generate site HTML with `bundle exec jekyll build`, and explain the changes to the HTML in your pull request. See README.md for more information.* -->
Review comment:
It's talking about the output from Jekyll. Markdown and HTML changes both have to be included in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org