You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/20 06:46:17 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue #8238: Add test cases for SQL parser cache
terrymanu opened a new issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238
- [ ] Add test case for ParseTreeCacheBuilder
- [ ] Add test case for ParseTreeCacheLoader
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking edited a comment on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
kimmking edited a comment on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-731012258
@panda-luo @laingke
You two should be picking up a half of these four tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] laingke commented on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
laingke commented on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-730945565
Please assgin to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-730960233
Welcome, I just assign the issue to you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-736436860
> @terrymanu I encountered difficulties when coding `ParseTreeCacheLoaderTest`.
>
> `SQLParserFactory.newInstance` is calling `SQLParserFacade` to create a singleton, and this facade is implemented in module `shardingsphere-sql-parser-dialect`, which is dependce on `shardingsphere-sql-parser-engine`.
>
> When initializing `SQLParserExecutor`, it will cacuse `UnsupportedOperationException: Cannot support database type`
>
> I have no idea how to assert, and can you support any suggestion?
>
> Thanks.
Please mock sqlParserExecutor after new ParseTreeCacheLoader, and use reflection to set your mock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] laingke commented on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
laingke commented on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-734314565
@terrymanu I encountered difficulties when coding `ParseTreeCacheLoaderTest`.
`SQLParserFactory.newInstance` is calling `SQLParserFacade` to create a singleton, and this facade is implemented in module `shardingsphere-sql-parser-dialect`, which is dependce on `shardingsphere-sql-parser-engine`.
When initializing `SQLParserExecutor`, it will cacuse `UnsupportedOperationException: Cannot support database type`
I have no idea how to assert, and can you support any suggestion?
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero closed issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-734079063
@laingke @panda-luo Hi, any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] panda-luo commented on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
panda-luo commented on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-730945529
Would like to claim this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-731012258
@panda-luo @laingke
You two should be pick a half of these four tasks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] panda-luo commented on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
panda-luo commented on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-731575916
I'll handle the rest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] laingke commented on issue #8238: Add test cases for SQL parser cache
Posted by GitBox <gi...@apache.org>.
laingke commented on issue #8238:
URL: https://github.com/apache/shardingsphere/issues/8238#issuecomment-731016756
Got it, I will handle ParseTreeCacheBuilder and ParseTreeCacheLoader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org