You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/19 05:21:29 UTC
[GitHub] [incubator-pinot] snleee opened a new pull request #5410: Fix flaky test for InterSegmentResultTableMultiValueQueriesTest
snleee opened a new pull request #5410:
URL: https://github.com/apache/incubator-pinot/pull/5410
The test was checking 1st row of the group by result, where all
10 aggregated group by values are the same. So, sometimes the test
fails because the order of 10 resulting rows is somtimes different.
Fixing this issue by adding "TOP 1" to have deterministic result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] snleee commented on pull request #5410: Fix flaky test for InterSegmentResultTableMultiValueQueriesTest
Posted by GitBox <gi...@apache.org>.
snleee commented on pull request #5410:
URL: https://github.com/apache/incubator-pinot/pull/5410#issuecomment-630587792
For `SELECT PERCENTILE50MV(column6) FROM testTable group by column7
`, the first row of the query result is mostly `372`; however, it sometimes return `386` as the first row of the result
```
java.lang.AssertionError: Lists differ at element [0]: 372 != 386 expected [372] but found [386]
Expected :372
Actual :386
<Click to see difference>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] snleee merged pull request #5410: Fix flaky test for InterSegmentResultTableMultiValueQueriesTest
Posted by GitBox <gi...@apache.org>.
snleee merged pull request #5410:
URL: https://github.com/apache/incubator-pinot/pull/5410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] snleee commented on pull request #5410: Fix flaky test for InterSegmentResultTableMultiValueQueriesTest
Posted by GitBox <gi...@apache.org>.
snleee commented on pull request #5410:
URL: https://github.com/apache/incubator-pinot/pull/5410#issuecomment-631863120
@mcvsubbu @mayankshriv Can you review this again? I have added the filter so now the result is truly deterministic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] snleee edited a comment on pull request #5410: Fix flaky test for InterSegmentResultTableMultiValueQueriesTest
Posted by GitBox <gi...@apache.org>.
snleee edited a comment on pull request #5410:
URL: https://github.com/apache/incubator-pinot/pull/5410#issuecomment-630587792
e.g. `SELECT PERCENTILE50MV(column6) FROM testTable group by column7
`, the first row of the query result is mostly `372`; however, it sometimes return `386` as the first row of the result
```
java.lang.AssertionError: Lists differ at element [0]: 372 != 386 expected [372] but found [386]
Expected :372
Actual :386
<Click to see difference>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mayankshriv commented on pull request #5410: Fix flaky test for InterSegmentResultTableMultiValueQueriesTest
Posted by GitBox <gi...@apache.org>.
mayankshriv commented on pull request #5410:
URL: https://github.com/apache/incubator-pinot/pull/5410#issuecomment-630934467
In case of ties (multiple groups with same value), using `TOP 1` is also prone to the same issue. You can either fix the group by adding a filter, or using comparison code that queries for a larger top K and can handle ties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org