You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Seunghan-Jung (via GitHub)" <gi...@apache.org> on 2024/04/05 17:35:02 UTC
[PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]
Seunghan-Jung opened a new pull request, #13276:
URL: https://github.com/apache/lucene/pull/13276
### Description
`FieldHighlighter` always sorts the final selected passages based on startOffset, but this may not align with the user's intentions.
For example, in the case of Solr's multiValue fields, the order might just be a simple listing of items without any significance. In such cases, the order in which passages appear is not important. It might be more effective to maintain sorting by score in these situations.
Therefore, it seems necessary to allow for the final sorting criteria to be determined in accordance with the user's intentions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]
Posted by "Seunghan-Jung (via GitHub)" <gi...@apache.org>.
Seunghan-Jung commented on code in PR #13276:
URL: https://github.com/apache/lucene/pull/13276#discussion_r1611850876
##########
lucene/CHANGES.txt:
##########
@@ -298,6 +298,8 @@ Improvements
* GITHUB#13385: Add Intervals.noIntervals() method to produce an empty IntervalsSource.
(Aniketh Jain, Uwe Schindler, Alan Woodward))
+* GITHUB#13276: UnifiedHighlighter: new 'passageSortComparator' option to allow sorting other than offset order. (Seunghan Jung)
Review Comment:
Thank you, @dsmiley
I have added it to the changes.txt myself. Could you please check it?
During this process, a rebase on main was necessary, so a force-push was performed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #13276:
URL: https://github.com/apache/lucene/pull/13276#issuecomment-2127252097
I like this change; very nice! I shall merge it. Please share how I shall list you in CHANGES.txt.
Proposed text under improvements to 9.11:
> GITHUB#13276: UnifiedHighlighter: new 'passageSortComparator' option to not do offset order (YOUR NAME)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #13276:
URL: https://github.com/apache/lucene/pull/13276#discussion_r1612090361
##########
lucene/CHANGES.txt:
##########
@@ -298,6 +298,8 @@ Improvements
* GITHUB#13385: Add Intervals.noIntervals() method to produce an empty IntervalsSource.
(Aniketh Jain, Uwe Schindler, Alan Woodward))
+* GITHUB#13276: UnifiedHighlighter: new 'passageSortComparator' option to allow sorting other than offset order. (Seunghan Jung)
Review Comment:
Looks good.
Please don't force-push to a PR. Instead, simply merge from main (and resolve conflicts).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13276:
URL: https://github.com/apache/lucene/pull/13276#issuecomment-2067416686
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]
Posted by "Seunghan-Jung (via GitHub)" <gi...@apache.org>.
Seunghan-Jung commented on code in PR #13276:
URL: https://github.com/apache/lucene/pull/13276#discussion_r1612190552
##########
lucene/CHANGES.txt:
##########
@@ -298,6 +298,8 @@ Improvements
* GITHUB#13385: Add Intervals.noIntervals() method to produce an empty IntervalsSource.
(Aniketh Jain, Uwe Schindler, Alan Woodward))
+* GITHUB#13276: UnifiedHighlighter: new 'passageSortComparator' option to allow sorting other than offset order. (Seunghan Jung)
Review Comment:
Oh, I will keep that in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]
Posted by "Seunghan-Jung (via GitHub)" <gi...@apache.org>.
Seunghan-Jung commented on code in PR #13276:
URL: https://github.com/apache/lucene/pull/13276#discussion_r1611850876
##########
lucene/CHANGES.txt:
##########
@@ -298,6 +298,8 @@ Improvements
* GITHUB#13385: Add Intervals.noIntervals() method to produce an empty IntervalsSource.
(Aniketh Jain, Uwe Schindler, Alan Woodward))
+* GITHUB#13276: UnifiedHighlighter: new 'passageSortComparator' option to allow sorting other than offset order. (Seunghan Jung)
Review Comment:
Thank you, @dsmiley
I have added it to the changes.txt myself. Could you please check it?
During this process, a rebase on apache:main was necessary, so a force-push was performed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #13276:
URL: https://github.com/apache/lucene/pull/13276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Add 'passageSortComparator' option in FieldHighlighter [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13276:
URL: https://github.com/apache/lucene/pull/13276#issuecomment-2106427848
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org