[GitHub] mistercrunch commented on a change in pull request #4272: [geo] Add JS controls to remaining layers

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4272: [geo] Add JS controls to remaining layers
URL: https://github.com/apache/incubator-superset/pull/4272#discussion_r163398889
 
 

 ##########
 File path: superset/assets/visualizations/deckgl/layers/screengrid.jsx
 ##########
 @@ -1,13 +1,22 @@
 import { ScreenGridLayer } from 'deck.gl';
 
-export default function getLayer(formData, payload) {
+import * as common from './common';
+import sandboxedEval from '../../../javascripts/modules/sandbox';
+
+export default function getLayer(formData, payload, slice) {
   const fd = formData;
   const c = fd.color_picker;
-  const data = payload.data.features.map(d => ({
+  let data = payload.data.features.map(d => ({
     ...d,
     color: [c.r, c.g, c.b, 255 * c.a],
   }));
 
+  if (fd.js_datapoint_mutator) {
 
 Review comment:
   Same here...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services