You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2023/01/04 12:53:59 UTC
[GitHub] [httpcomponents-client] alturkovic opened a new pull request, #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method
alturkovic opened a new pull request, #404:
URL: https://github.com/apache/httpcomponents-client/pull/404
Some implementations might depend on a variable present in the `HttpContext` which is available in most other methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method
Posted by GitBox <gi...@apache.org>.
ok2c commented on PR #404:
URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370975027
@alturkovic Great. But please do it nicely and suppress deprecation warnings in the new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method
Posted by GitBox <gi...@apache.org>.
ok2c merged PR #404:
URL: https://github.com/apache/httpcomponents-client/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method
Posted by GitBox <gi...@apache.org>.
ok2c commented on PR #404:
URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370957675
@alturkovic The change-set breaks backward compatibility with 5.0 APIs.
By the way, one may be better off writing a custom `SSLConnectionSocketFactory` instead of trying to make the default one work in all specific cases.
```
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 46.847 s
[INFO] Finished at: 2023-01-04T13:46:47Z
[INFO] ------------------------------------------------------------------------
Error: Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.16.0:cmp (default) on project httpclient5: There is at least one incompatibility: org.apache.hc.client5.http.ssl.SSLConnectionSocketFactory.prepareSocket(javax.net.ssl.SSLSocket):METHOD_REMOVED -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method
Posted by GitBox <gi...@apache.org>.
ok2c commented on PR #404:
URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370987346
@alturkovic Please add `@SuppressWarnings("deprecation")` annotation to the new method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] alturkovic commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method
Posted by GitBox <gi...@apache.org>.
alturkovic commented on PR #404:
URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370959011
@ok2c Oops, added the method back. I understand, I just thought that having `HttpContext` available by default made sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method
Posted by GitBox <gi...@apache.org>.
ok2c commented on PR #404:
URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370961882
@alturkovic Please deprecate the old method in favor of the new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] alturkovic commented on pull request #404: feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method
Posted by GitBox <gi...@apache.org>.
alturkovic commented on PR #404:
URL: https://github.com/apache/httpcomponents-client/pull/404#issuecomment-1370980479
Sorry, I do not know what you mean by that, I took a look how other methods are deprecated (i.e.: `org.apache.hc.client5.http.ssl.ClientTlsStrategyBuilder#setTlsDetailsFactory`) and I do not see any suppressions? Would you mind explaining a bit more what needs to be done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org