[jira] [Commented] (CALCITE-4461) Do not cast to logical node inside Enumerable rules

["Rui Wang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276063#comment-17276063 ] 

Rui Wang commented on CALCITE-4461:
-----------------------------------

merged via https://github.com/apache/calcite/commit/1bf6b08a81f471f979e1b52174f225f03ff77a2e!

> Do not cast to logical node inside Enumerable rules
> ---------------------------------------------------
>
>                 Key: CALCITE-4461
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4461
>             Project: Calcite
>          Issue Type: Task
>          Components: core
>    Affects Versions: 1.26.0
>            Reporter: Vladimir Ozerov
>            Assignee: Vladimir Ozerov
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.27.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Currently, some {{Enumerable}} rules work with the base operator classes, such as {{Join}}, while others have an explicit cast to {{Logical}} counterparts, such as `LogicalJoin`, {{LogicalProject}}, etc. This makes it impossible to convert custom non-logical nodes into {{Enumerable}} using the built-in rules because such an invocation will fail with a {{ClassCastException}}.
> The proposal is to change all existing rules so that they work with the base {{RelNode}} classes.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)