You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Jonathan Hsieh <jo...@cloudera.com> on 2012/09/13 21:58:56 UTC
HBase code coverage and code analysis available on analysis.apache.org.
Hooray! we have a "sonar" code coverage and code metrics job setup on
analysis.apache.org!
https://analysis.apache.org/dashboard/index/org.apache.hbase:hbase
It looks like it may only run the small tests, but this still provides good
data points.
I found this especially interesting:
https://analysis.apache.org/plugins/resource/103783?page=org.sonar.plugins.design.ui.page.DesignPage
This was filed a ways back as INFRA-4581 -- if we have other things we want
to add tweak, we could file more INFRA jiras.
https://issues.apache.org/jira/browse/INFRA-4581<https://issues.apache.org/jira/browse/INFRA-4581#comment-13455178>
Jon.
--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// jon@cloudera.com
Re: HBase code coverage and code analysis available on analysis.apache.org.
Posted by Enis Söztutar <en...@hortonworks.com>.
Can we exclude the generated classes. For clover code coverage, we do
exclude those (see pom.xml).
Thanks,
Enis
On Thu, Sep 13, 2012 at 2:26 PM, Jonathan Hsieh <jo...@cloudera.com> wrote:
> I think part of the problem they (INFRA) had was that the findbugs wasn't
> able to pick up our existing (incomplete) list of findbugs violations. We
> never got findbugs to 0 we haven't started enforcing it.
>
> If anyone is interested in improving this analysis page, go ahead and run
> with it. I think we'd all appreciate it. :)
>
> Jon.
>
> On Thu, Sep 13, 2012 at 2:14 PM, Andrew Purtell <ap...@apache.org>
> wrote:
>
> > Also the 'array is stored directly' violation class, lots of probable
> > false positives there due to our use of byte[]
> >
> > On Thu, Sep 13, 2012 at 2:05 PM, Elliott Clark <ec...@stumbleupon.com>
> > wrote:
> > > Yeah there are some really great things in there. Thanks.
> > >
> > > Is there anyway to have an ignore list like findbugs, so generated code
> > can
> > > be ignored ?
> > >
> > > On Thu, Sep 13, 2012 at 1:21 PM, lars hofhansl <lh...@yahoo.com>
> > wrote:
> > >
> > >> There are some gems in there.
> > >>
> > >>
> > >>
> > >> ________________________________
> > >> From: Jonathan Hsieh <jo...@cloudera.com>
> > >> To: dev@hbase.apache.org
> > >> Sent: Thursday, September 13, 2012 12:58 PM
> > >> Subject: HBase code coverage and code analysis available on
> > >> analysis.apache.org.
> > >>
> > >> Hooray! we have a "sonar" code coverage and code metrics job setup on
> > >> analysis.apache.org!
> > >>
> > >> https://analysis.apache.org/dashboard/index/org.apache.hbase:hbase
> > >>
> > >> It looks like it may only run the small tests, but this still provides
> > good
> > >> data points.
> > >>
> > >> I found this especially interesting:
> > >>
> > >>
> >
> https://analysis.apache.org/plugins/resource/103783?page=org.sonar.plugins.design.ui.page.DesignPage
> > >>
> > >> This was filed a ways back as INFRA-4581 -- if we have other things we
> > want
> > >> to add tweak, we could file more INFRA jiras.
> > >> https://issues.apache.org/jira/browse/INFRA-4581<
> > >> https://issues.apache.org/jira/browse/INFRA-4581#comment-13455178>
> > >>
> > >> Jon.
> > >>
> > >> --
> > >> // Jonathan Hsieh (shay)
> > >> // Software Engineer, Cloudera
> > >> // jon@cloudera.com
> > >>
> >
> >
> >
> > --
> > Best regards,
> >
> > - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet
> > Hein (via Tom White)
> >
>
>
>
> --
> // Jonathan Hsieh (shay)
> // Software Engineer, Cloudera
> // jon@cloudera.com
>
Re: HBase code coverage and code analysis available on analysis.apache.org.
Posted by Jonathan Hsieh <jo...@cloudera.com>.
I think part of the problem they (INFRA) had was that the findbugs wasn't
able to pick up our existing (incomplete) list of findbugs violations. We
never got findbugs to 0 we haven't started enforcing it.
If anyone is interested in improving this analysis page, go ahead and run
with it. I think we'd all appreciate it. :)
Jon.
On Thu, Sep 13, 2012 at 2:14 PM, Andrew Purtell <ap...@apache.org> wrote:
> Also the 'array is stored directly' violation class, lots of probable
> false positives there due to our use of byte[]
>
> On Thu, Sep 13, 2012 at 2:05 PM, Elliott Clark <ec...@stumbleupon.com>
> wrote:
> > Yeah there are some really great things in there. Thanks.
> >
> > Is there anyway to have an ignore list like findbugs, so generated code
> can
> > be ignored ?
> >
> > On Thu, Sep 13, 2012 at 1:21 PM, lars hofhansl <lh...@yahoo.com>
> wrote:
> >
> >> There are some gems in there.
> >>
> >>
> >>
> >> ________________________________
> >> From: Jonathan Hsieh <jo...@cloudera.com>
> >> To: dev@hbase.apache.org
> >> Sent: Thursday, September 13, 2012 12:58 PM
> >> Subject: HBase code coverage and code analysis available on
> >> analysis.apache.org.
> >>
> >> Hooray! we have a "sonar" code coverage and code metrics job setup on
> >> analysis.apache.org!
> >>
> >> https://analysis.apache.org/dashboard/index/org.apache.hbase:hbase
> >>
> >> It looks like it may only run the small tests, but this still provides
> good
> >> data points.
> >>
> >> I found this especially interesting:
> >>
> >>
> https://analysis.apache.org/plugins/resource/103783?page=org.sonar.plugins.design.ui.page.DesignPage
> >>
> >> This was filed a ways back as INFRA-4581 -- if we have other things we
> want
> >> to add tweak, we could file more INFRA jiras.
> >> https://issues.apache.org/jira/browse/INFRA-4581<
> >> https://issues.apache.org/jira/browse/INFRA-4581#comment-13455178>
> >>
> >> Jon.
> >>
> >> --
> >> // Jonathan Hsieh (shay)
> >> // Software Engineer, Cloudera
> >> // jon@cloudera.com
> >>
>
>
>
> --
> Best regards,
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet
> Hein (via Tom White)
>
--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// jon@cloudera.com
Re: HBase code coverage and code analysis available on analysis.apache.org.
Posted by Andrew Purtell <ap...@apache.org>.
Also the 'array is stored directly' violation class, lots of probable
false positives there due to our use of byte[]
On Thu, Sep 13, 2012 at 2:05 PM, Elliott Clark <ec...@stumbleupon.com> wrote:
> Yeah there are some really great things in there. Thanks.
>
> Is there anyway to have an ignore list like findbugs, so generated code can
> be ignored ?
>
> On Thu, Sep 13, 2012 at 1:21 PM, lars hofhansl <lh...@yahoo.com> wrote:
>
>> There are some gems in there.
>>
>>
>>
>> ________________________________
>> From: Jonathan Hsieh <jo...@cloudera.com>
>> To: dev@hbase.apache.org
>> Sent: Thursday, September 13, 2012 12:58 PM
>> Subject: HBase code coverage and code analysis available on
>> analysis.apache.org.
>>
>> Hooray! we have a "sonar" code coverage and code metrics job setup on
>> analysis.apache.org!
>>
>> https://analysis.apache.org/dashboard/index/org.apache.hbase:hbase
>>
>> It looks like it may only run the small tests, but this still provides good
>> data points.
>>
>> I found this especially interesting:
>>
>> https://analysis.apache.org/plugins/resource/103783?page=org.sonar.plugins.design.ui.page.DesignPage
>>
>> This was filed a ways back as INFRA-4581 -- if we have other things we want
>> to add tweak, we could file more INFRA jiras.
>> https://issues.apache.org/jira/browse/INFRA-4581<
>> https://issues.apache.org/jira/browse/INFRA-4581#comment-13455178>
>>
>> Jon.
>>
>> --
>> // Jonathan Hsieh (shay)
>> // Software Engineer, Cloudera
>> // jon@cloudera.com
>>
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet
Hein (via Tom White)
Re: HBase code coverage and code analysis available on analysis.apache.org.
Posted by Elliott Clark <ec...@stumbleupon.com>.
Yeah there are some really great things in there. Thanks.
Is there anyway to have an ignore list like findbugs, so generated code can
be ignored ?
On Thu, Sep 13, 2012 at 1:21 PM, lars hofhansl <lh...@yahoo.com> wrote:
> There are some gems in there.
>
>
>
> ________________________________
> From: Jonathan Hsieh <jo...@cloudera.com>
> To: dev@hbase.apache.org
> Sent: Thursday, September 13, 2012 12:58 PM
> Subject: HBase code coverage and code analysis available on
> analysis.apache.org.
>
> Hooray! we have a "sonar" code coverage and code metrics job setup on
> analysis.apache.org!
>
> https://analysis.apache.org/dashboard/index/org.apache.hbase:hbase
>
> It looks like it may only run the small tests, but this still provides good
> data points.
>
> I found this especially interesting:
>
> https://analysis.apache.org/plugins/resource/103783?page=org.sonar.plugins.design.ui.page.DesignPage
>
> This was filed a ways back as INFRA-4581 -- if we have other things we want
> to add tweak, we could file more INFRA jiras.
> https://issues.apache.org/jira/browse/INFRA-4581<
> https://issues.apache.org/jira/browse/INFRA-4581#comment-13455178>
>
> Jon.
>
> --
> // Jonathan Hsieh (shay)
> // Software Engineer, Cloudera
> // jon@cloudera.com
>
Re: HBase code coverage and code analysis available on analysis.apache.org.
Posted by lars hofhansl <lh...@yahoo.com>.
There are some gems in there.
________________________________
From: Jonathan Hsieh <jo...@cloudera.com>
To: dev@hbase.apache.org
Sent: Thursday, September 13, 2012 12:58 PM
Subject: HBase code coverage and code analysis available on analysis.apache.org.
Hooray! we have a "sonar" code coverage and code metrics job setup on
analysis.apache.org!
https://analysis.apache.org/dashboard/index/org.apache.hbase:hbase
It looks like it may only run the small tests, but this still provides good
data points.
I found this especially interesting:
https://analysis.apache.org/plugins/resource/103783?page=org.sonar.plugins.design.ui.page.DesignPage
This was filed a ways back as INFRA-4581 -- if we have other things we want
to add tweak, we could file more INFRA jiras.
https://issues.apache.org/jira/browse/INFRA-4581<https://issues.apache.org/jira/browse/INFRA-4581#comment-13455178>
Jon.
--
// Jonathan Hsieh (shay)
// Software Engineer, Cloudera
// jon@cloudera.com