[jira] [Closed] (NET-589) The managing of the KeepAliveReplyTimeout masks the user's setting

["Fabio Scippacercola (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NET-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fabio Scippacercola closed NET-589.
-----------------------------------
    Resolution: Invalid

Sorry for my ticket, redoing a more accurate code review, I understood that the logic works fine for where the class is used.

> The managing of the KeepAliveReplyTimeout masks the user's setting
> ------------------------------------------------------------------
>
>                 Key: NET-589
>                 URL: https://issues.apache.org/jira/browse/NET-589
>             Project: Commons Net
>          Issue Type: Bug
>          Components: FTP
>    Affects Versions: 3.3
>            Reporter: Fabio Scippacercola
>            Priority: Minor
>
> The class FTPClient uses a convenience static and private class for managing the KeepAlive: CSL. However, this class sets in its constructor the maximum waiting time for the KeepAliveReply (FTPClient:3671), overriding any users's setting for the FTPClient.setSoTimeout.
>  
> If I am not wrong, "setSoTimeout" should be set right before to call the "__noop" operation in FTPClient:3685, saving the original (user-defined) value for the SoTimeout, and resetting it after the invocation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)