You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "RussellSpitzer (via GitHub)" <gi...@apache.org> on 2026/08/26 03:56:04 UTC
[PR] API, Core, Parquet: Model the file type as its own nested type [iceberg]
RussellSpitzer opened a new pull request, #17821:
URL: https://github.com/apache/iceberg/pull/17821
An alternative implementation of the `file` logical type from #17808 which treats File as a new non-primitive special type. This is a little similar to Variant in that all visitors now have special handling for File type and you can't write a "bad" visitor which treats a File like a struct when it shouldn'd.
- **#17808 (design A):** `Types.FileType extends StructType`, `typeId() == STRUCT`.
Visitors see a struct and behave correctly for free; the few places that must
not expand or rewrite a file carry `isFileType()` guards.
- This PR (design B): Types.FileType is a new Type with it's own typeId. Vistors either fall back to struct behavior with FileType.asStruct or have custom logic file()
---
**AI Disclosure**
- Model: Claude Opus 5
- Platform/Tool: Cursor
- Human Oversight: partially reviewed
- Prompt Summary: Implement the `file` logical type as a standalone `NestedType`
with its own `TypeID` and per-visitor `file()` hooks, as an alternative to the
`StructType`-subclass approach in #17808, and measure the difference in files
touched, lines changed, engine breakage, and latent switch-statement risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core, Parquet: Model the file type as its own nested type [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17821: API, Core, Parquet: Model the file type as its own nested type
URL: https://github.com/apache/iceberg/pull/17821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core, Parquet: Model the file type as its own nested type [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17821:
URL: https://github.com/apache/iceberg/pull/17821#issuecomment-5986081104
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API, Core, Parquet: Model the file type as its own nested type [iceberg]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17821:
URL: https://github.com/apache/iceberg/pull/17821#issuecomment-5861271766
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org