[GitHub] jadams-tresys commented on a change in pull request #55: Fixes the issue of separated empty optional elements, (ie. 1:2::4:5).

[GitBox <gi...@apache.org>]

jadams-tresys commented on a change in pull request #55: Fixes the issue of separated empty optional elements, (ie. 1:2::4:5).
URL: https://github.com/apache/incubator-daffodil/pull/55#discussion_r175465713
 
 

 ##########
 File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/LocalElementGrammarMixin.scala
 ##########
 @@ -211,7 +214,7 @@ trait LocalElementGrammarMixin extends GrammarMixin { self: ElementBase =>
       case (TrailingStr, Implicit__, UNB, ___) => separatedContentWithMinUnboundedWithoutTrailingEmpties // we're depending on optionalEmptyPart failing on empty content.
       case (TrailingStr, Implicit__, max, ___) => separatedContentAtMostNWithoutTrailingEmpties
       case (Always_____, Implicit__, UNB, ___) => separatedContentWithMinUnbounded
-      case (Always_____, Implicit__, max, ___) => separatedContentAtMostN
+      case (Always_____, Implicit__, max, ___) => separatedContentAtMostNWithoutTrailingEmpties
 
 Review comment:
   I am not 100% sure that this is correct behaviour, but it results in the same behaviour as before these changes.  This prevents TestArrayOptionalElem.test_backtrack1Text from failing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services