You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2017/02/27 21:42:32 UTC
[GitHub] flink pull request #3425: [FLINK-5921] [table] Add custom data types for row...
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/3425
[FLINK-5921] [table] Add custom data types for rowtime and proctime.
We add a custom data type for the result of the `rowtime()` and `proctime()` marker functions to easier identify the chosen time semantics in when translating window operations.
Both method return a constant timestamp (0L) which is injected during constant expression reduction.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink tableTimeTypes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3425.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3425
----
commit 6cc819b88c408de7b42a968d2a8cdb21ab927ffd
Author: Fabian Hueske <fh...@apache.org>
Date: 2017-02-25T23:28:54Z
[FLINK-5921] [table] Add custom data types for rowtime and proctime.
- proctime() and rowtime() return constont timestamp (0L).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3425: [FLINK-5921] [table] Add custom data types for row...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3425#discussion_r103384285
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala ---
@@ -327,6 +329,15 @@ object FunctionGenerator {
)
)
+ // generate a constant for time indicator functions.
+ // this is a temporary solution and will be removed when FLINK-5884 is implemented.
+ case ProcTimeExtractor | EventTimeExtractor =>
+ Some(new CallGenerator {
+ override def generate(codeGenerator: CodeGenerator, operands: Seq[GeneratedExpression]) = {
+ GeneratedExpression("0L", "false", "", LONG_TYPE_INFO)
--- End diff --
Can we change `LONG_TYPE_INFO` to `SqlTimeTypeInfo.TIMESTAMP`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3425: [FLINK-5921] [table] Add custom data types for rowtime an...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3425
@fhueske Thanks for updating, the PR looks very good to me. I look forward to merge.
Best,
SunJincheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3425: [FLINK-5921] [table] Add custom data types for rowtime an...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3425
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3425: [FLINK-5921] [table] Add custom data types for rowtime an...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3425
Thanks for the feedback @sunjincheng121 and @twalthr
Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3425: [FLINK-5921] [table] Add custom data types for row...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske closed the pull request at:
https://github.com/apache/flink/pull/3425
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3425: [FLINK-5921] [table] Add custom data types for row...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3425#discussion_r103399995
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala ---
@@ -327,6 +329,15 @@ object FunctionGenerator {
)
)
+ // generate a constant for time indicator functions.
+ // this is a temporary solution and will be removed when FLINK-5884 is implemented.
+ case ProcTimeExtractor | EventTimeExtractor =>
+ Some(new CallGenerator {
+ override def generate(codeGenerator: CodeGenerator, operands: Seq[GeneratedExpression]) = {
+ GeneratedExpression("0L", "false", "", LONG_TYPE_INFO)
--- End diff --
Yes, thanks for the hint
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3425: [FLINK-5921] [table] Add custom data types for rowtime an...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3425
I'm fine with this temporary solution. +1 for merging until FLINK-5884 is fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---