You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "Jens Geyer (Jira)" <ji...@apache.org> on 2026/10/20 22:23:00 UTC

[jira] [Resolved] (THRIFT-6348) Go test Makefiles write ThriftTest.thrift copies into the source tree

     [ https://issues.apache.org/jira/browse/THRIFT-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-6348.
--------------------------------
    Fix Version/s: 0.26.0
         Assignee: Sylwester Lachiewicz
       Resolution: Fixed

> Go test Makefiles write ThriftTest.thrift copies into the source tree
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-6348
>                 URL: https://issues.apache.org/jira/browse/THRIFT-6348
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process, Go - Library
>    Affects Versions: 0.25.0
>            Reporter: Sylwester Lachiewicz
>            Assignee: Sylwester Lachiewicz
>            Priority: Trivial
>             Fix For: 0.26.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> [lib/go/test/Makefile.am|https://github.com/apache/thrift/blob/master/lib/go/test/Makefile.am#L77] writes a filtered copy of {{test/ThriftTest.thrift}} next to the sources ({{grep -v 'set<Insanity>'}}), and [test/go/Makefile.am|https://github.com/apache/thrift/blob/master/test/go/Makefile.am#L29] copies it unchanged; both copies are listed in {{.gitignore}}. Whether those two files exist therefore depends on whether a build has run, which trips any tool that sweeps the tree for {{*.thrift}} ({{lib/go/test/IncludesTest.thrift}} and {{NamespacedTest.thrift}} include the copy and fail to compile without it).
> The filtered copy can live under {{gopath/}}, which is already a gitignored build directory, with {{-I gopath}} on the compiler call so the includes resolve; {{test/go}} can pass {{$(top_srcdir)/test/ThriftTest.thrift}} directly. The generated package tree is the same.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)