You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/08/29 10:48:45 UTC
Re: Review Request 68535: Updated Python 3 dependencies for 3.7.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68535/
-----------------------------------------------------------
(Updated Aug. 29, 2018, 12:48 p.m.)
Review request for mesos, Benjamin Bannier and Robin Gögge.
Summary (updated)
-----------------
Updated Python 3 dependencies for 3.7.
Bugs: MESOS-9186
https://issues.apache.org/jira/browse/MESOS-9186
Repository: mesos
Description (updated)
-------
All the dependencies for Python 3 are now set using `==` so that we will
only need to update them when a new Python version is being released.
The files `pip-requirements` have been renamed depending on which
versions of pip should use them, this way we do not end up with
Python 2 trying to install Python 3 dependencies and vice versa.
Diffs (updated)
-----
src/python/cli_new/pip-requirements.txt 8645912a63b22878f477e96bfa8bc95abe893f85
src/python/cli_new/tox.ini a9a2e69156484a4d172a2746f8cc51089445ae17
support/build-virtualenv eb6346487343716d43e78548eb678565742dcce3
support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990
support/pip-requirements.txt
support/python3/pip-requirements.txt PRE-CREATION
Diff: https://reviews.apache.org/r/68535/diff/2/
Changes: https://reviews.apache.org/r/68535/diff/1-2/
Testing
-------
Used the scripts and saw that the error describe in MESOS-9186 is gone. Multiple packages had issues with Python 3.7 and I have used versions that include fixes for those.
Thanks,
Armand Grillet
Re: Review Request 68535: Updated Python 3 dependencies for 3.7.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68535/#review208089
-----------------------------------------------------------
PASS: Mesos patch 68535 was successfully built and tested.
Reviews applied: `['68535']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2259/mesos-review-68535
- Mesos Reviewbot Windows
On Aug. 29, 2018, 6:48 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68535/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2018, 6:48 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Robin Gögge.
>
>
> Bugs: MESOS-9186
> https://issues.apache.org/jira/browse/MESOS-9186
>
>
> Repository: mesos
>
>
> Description
> -------
>
> All the dependencies for Python 3 are now set using `==` so that we will
> only need to update them when a new Python version is being released.
>
> The files `pip-requirements` have been renamed depending on which
> versions of pip should use them, this way we do not end up with
> Python 2 trying to install Python 3 dependencies and vice versa.
>
>
> Diffs
> -----
>
> src/python/cli_new/pip-requirements.txt 8645912a63b22878f477e96bfa8bc95abe893f85
> src/python/cli_new/tox.ini a9a2e69156484a4d172a2746f8cc51089445ae17
> support/build-virtualenv eb6346487343716d43e78548eb678565742dcce3
> support/mesos-style.py 0243eb33b983d0bb94326efbaa19114ec8b08990
> support/pip-requirements.txt
> support/python3/pip-requirements.txt PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68535/diff/2/
>
>
> Testing
> -------
>
> Used the scripts and saw that the error describe in MESOS-9186 is gone. Multiple packages had issues with Python 3.7 and I have used versions that include fixes for those.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68535: Simplified Python dependencies management.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68535/#review208159
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Aug. 30, 2018, 10:07 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68535/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 10:07 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Kevin Klues, and Robin Gögge.
>
>
> Bugs: MESOS-8206
> https://issues.apache.org/jira/browse/MESOS-8206
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the upgrade of the Python package to Python 3.6, tox handles
> dependencies for the new CLI and the Mesos Python package (MESOS-8206).
>
>
> Diffs
> -----
>
> support/build-virtualenv eb6346487343716d43e78548eb678565742dcce3
> support/pip-requirements.txt 89c2de287bc26bbde3006b587a4a8c1bae6f600b
>
>
> Diff: https://reviews.apache.org/r/68535/diff/4/
>
>
> Testing
> -------
>
> Used the scripts and saw that the error describe in MESOS-9186 is gone. Multiple packages had issues with Python 3.7 and I have used versions that include fixes for those.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 68535: Simplified Python dependencies management.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68535/
-----------------------------------------------------------
(Updated Aug. 30, 2018, 10:07 a.m.)
Review request for mesos, Benjamin Bannier, Kevin Klues, and Robin Gögge.
Changes
-------
Rebased and simplified.
Summary (updated)
-----------------
Simplified Python dependencies management.
Bugs: MESOS-8206
https://issues.apache.org/jira/browse/MESOS-8206
Repository: mesos
Description (updated)
-------
Following the upgrade of the Python package to Python 3.6, tox handles
dependencies for the new CLI and the Mesos Python package (MESOS-8206).
Diffs (updated)
-----
support/build-virtualenv eb6346487343716d43e78548eb678565742dcce3
support/pip-requirements.txt 89c2de287bc26bbde3006b587a4a8c1bae6f600b
Diff: https://reviews.apache.org/r/68535/diff/3/
Changes: https://reviews.apache.org/r/68535/diff/2-3/
Testing
-------
Used the scripts and saw that the error describe in MESOS-9186 is gone. Multiple packages had issues with Python 3.7 and I have used versions that include fixes for those.
Thanks,
Armand Grillet